[GitHub] [arrow-datafusion-python] andygrove commented on a diff in pull request #93: Fixes #81 - Add CI workflow for source distribution

[GitBox <gi...@apache.org>]

andygrove commented on code in PR #93:
URL: https://github.com/apache/arrow-datafusion-python/pull/93#discussion_r1037297490


##########
pyproject.toml:
##########
@@ -55,4 +55,9 @@ repository = "https://github.com/apache/arrow-datafusion-python"
 profile = "black"
 
 [tool.maturin]
-sdist-include = ["Cargo.lock"]
+include = [
+    { path = "Cargo.lock", format = "sdist" }
+]
+exclude = [".github/**", "ci/**", ".asf.yaml"]
+# Require Cargo.lock is up to date
+locked = true

Review Comment:
   Will this fail the build if Cargo.lock is not up-to-date? This action doesn't run until we tag the release candidate so there is a good chance this will fail unless we also have a CI check on PRs to make sure Cargo.lock is up-to-date?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org