You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/04/21 03:15:46 UTC

[GitHub] [incubator-mxnet] eric-haibin-lin opened a new issue #18120: MKLDNN header missing in recent mxnet nightly static builds

eric-haibin-lin opened a new issue #18120:
URL: https://github.com/apache/incubator-mxnet/issues/18120


   ```
   root@ip-172-31-37-108:/bps-mkl# pip3 install --pre mxnet-cu100 -f https://dist.mxnet.io/python/cu100  -U
   Collecting mxnet-cu100
     Downloading https://repo.mxnet.io/dist/python/cu100/mxnet_cu100-2.0.0b20200312-py2.py3-none-manylinux1_x86_64.whl (808.1MB)
   ```
   ```
   ls /usr/local/lib/python3.6/dist-packages/mxnet/include/
   dlpack  dmlc  mshadow  mxnet  nnvm
   ```
   
   Since mkldnn is turned on by default in Feb, the headers should be included, too
   
   @TaoLv 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] leezu commented on issue #18120: MKLDNN header missing in recent mxnet nightly static builds

Posted by GitBox <gi...@apache.org>.
leezu commented on issue #18120:
URL: https://github.com/apache/incubator-mxnet/issues/18120#issuecomment-621396395


   I think @mseth10 will fix it as part of his work on fixing CD


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] eric-haibin-lin commented on issue #18120: MKLDNN header missing in recent mxnet nightly static builds

Posted by GitBox <gi...@apache.org>.
eric-haibin-lin commented on issue #18120:
URL: https://github.com/apache/incubator-mxnet/issues/18120#issuecomment-628295369


   Actually I cannot find it now after i uninstalling mxnet and reinstall https://repo.mxnet.io/dist/python/cu100/mxnet_cu100-2.0.0b20200509-py2.py3-none-manylinux2014_x86_64.whl . Perhaps I didn't remove/cleanup the previous mxnet version correctly previously. 
   @TaoLv 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] leezu commented on issue #18120: MKLDNN header missing in recent mxnet nightly static builds

Posted by GitBox <gi...@apache.org>.
leezu commented on issue #18120:
URL: https://github.com/apache/incubator-mxnet/issues/18120#issuecomment-621395407


   @TaoLv agree https://github.com/apache/incubator-mxnet/pull/16857 is wrong. Now we only copy the headers on OSX platform which doesn't make any sense


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] leezu edited a comment on issue #18120: MKLDNN header missing in recent mxnet nightly static builds

Posted by GitBox <gi...@apache.org>.
leezu edited a comment on issue #18120:
URL: https://github.com/apache/incubator-mxnet/issues/18120#issuecomment-630361873


   The root cause of this issue is that there are a lot of non-standard hard-coded paths in various places of the installation script. Instead of continuing to maintain and hotpatch these, I suggest to just use the standard process and declare the files that need to be included as cmake `INSTALL` target.
   
   Then `cmake -DCMAKE_INSTALL_PREFIX=/tmp/mxnet ..; ninja install` will place all files that need to be packaged at the install prefix path, and the python setup.py only needs to package these files.. This will also simplify the CD setup..


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] TaoLv commented on issue #18120: MKLDNN header missing in recent mxnet nightly static builds

Posted by GitBox <gi...@apache.org>.
TaoLv commented on issue #18120:
URL: https://github.com/apache/incubator-mxnet/issues/18120#issuecomment-630269356


   No. It should have the following files:
   ```
   $ ll 3rdparty/mkldnn/build/install/include/
   total 812
   -rw-r--r-- 1 lvtao lvtao   2364 May 18 23:28 dnnl_config.h
   -rw-r--r-- 1 lvtao lvtao   2641 Apr 12 21:44 dnnl_debug.h
   -rw-r--r-- 1 lvtao lvtao 180648 May 11 17:25 dnnl.h
   -rw-r--r-- 1 lvtao lvtao 485168 May  7 22:23 dnnl.hpp
   -rw-r--r-- 1 lvtao lvtao   1887 May  7 22:23 dnnl_threadpool_iface.hpp
   -rw-r--r-- 1 lvtao lvtao  80051 May 11 17:25 dnnl_types.h
   -rw-r--r-- 1 lvtao lvtao   1079 May 18 23:28 dnnl_version.h
   -rw-r--r-- 1 lvtao lvtao    963 Apr 12 21:44 mkldnn_config.h
   -rw-r--r-- 1 lvtao lvtao    959 Apr 12 21:44 mkldnn_debug.h
   -rw-r--r-- 1 lvtao lvtao  34732 May  7 22:23 mkldnn_dnnl_mangling.h
   -rw-r--r-- 1 lvtao lvtao    935 Apr 12 21:44 mkldnn.h
   -rw-r--r-- 1 lvtao lvtao    943 Apr 12 21:44 mkldnn.hpp
   -rw-r--r-- 1 lvtao lvtao    959 Apr 12 21:44 mkldnn_types.h
   -rw-r--r-- 1 lvtao lvtao    967 Apr 12 21:44 mkldnn_version.h
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] leezu commented on issue #18120: MKLDNN header missing in recent mxnet nightly static builds

Posted by GitBox <gi...@apache.org>.
leezu commented on issue #18120:
URL: https://github.com/apache/incubator-mxnet/issues/18120#issuecomment-616931390


   FYI, I intend to switch the CD to cmake build in the coming days. It's currently blocked by https://github.com/apache/incubator-mxnet/issues/17557 because I'd like the CD to pass at least once prior to changing the build system.. #17557 may be fixed by https://github.com/apache/incubator-mxnet/pull/18025


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] TaoLv commented on issue #18120: MKLDNN header missing in recent mxnet nightly static builds

Posted by GitBox <gi...@apache.org>.
TaoLv commented on issue #18120:
URL: https://github.com/apache/incubator-mxnet/issues/18120#issuecomment-616937545


   I doubt it's caused by the fix in https://github.com/apache/incubator-mxnet/pull/16857. We have lost the mkldnn header folder since then. For example, in https://repo.mxnet.io/dist/python/mkl/mxnet_mkl-1.6.0b20191205-py2.py3-none-manylinux1_x86_64.whl.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] wms2537 commented on issue #18120: MKLDNN header missing in recent mxnet nightly static builds

Posted by GitBox <gi...@apache.org>.
wms2537 commented on issue #18120:
URL: https://github.com/apache/incubator-mxnet/issues/18120#issuecomment-630147645


   Only the following files are in the mkldnn folder
   `dnnl_config.h  dnnl_version.h
   `
   Is this normal?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] leezu edited a comment on issue #18120: MKLDNN header missing in recent mxnet nightly static builds

Posted by GitBox <gi...@apache.org>.
leezu edited a comment on issue #18120:
URL: https://github.com/apache/incubator-mxnet/issues/18120#issuecomment-616931390


   FYI, I intend to switch the CD to cmake build in the coming days. It's currently blocked by https://github.com/apache/incubator-mxnet/issues/17557 because I'd like the CD to pass at least once prior to changing the build system.. #17557 may be fixed by https://github.com/apache/incubator-mxnet/pull/18025
   
   However, the issue may be present in both cmake and make based staticbuilds.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] leezu commented on issue #18120: MKLDNN header missing in recent mxnet nightly static builds

Posted by GitBox <gi...@apache.org>.
leezu commented on issue #18120:
URL: https://github.com/apache/incubator-mxnet/issues/18120#issuecomment-628320911


   I looked at the CD pipeline and the mkldnn headers are correctly present at the time of building the wheel. The issue really is that
   
   https://github.com/apache/incubator-mxnet/blob/47a38d1101beb5897fe30c9d04f4599cd7636731/tools/pip/setup.py#L152-L154
   
   only runs if the variant is named `"*mkl"` but now we don't use this mkl naming scheme anymore.
   
   I'll open a PR to fix the setup.py script.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] leezu closed issue #18120: MKLDNN header missing in recent mxnet nightly static builds

Posted by GitBox <gi...@apache.org>.
leezu closed issue #18120:
URL: https://github.com/apache/incubator-mxnet/issues/18120


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] leezu closed issue #18120: MKLDNN header missing in recent mxnet nightly static builds

Posted by GitBox <gi...@apache.org>.
leezu closed issue #18120:
URL: https://github.com/apache/incubator-mxnet/issues/18120


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] leezu commented on issue #18120: MKLDNN header missing in recent mxnet nightly static builds

Posted by GitBox <gi...@apache.org>.
leezu commented on issue #18120:
URL: https://github.com/apache/incubator-mxnet/issues/18120#issuecomment-630361873


   The root cause of this issue is that there are a lot of non-standard hard-coded paths in various places of the installation script. Instead of continuing to maintain and hotpatch these, I suggest to just use the standard process and declare the files that need to be included as cmake `INSTALL` target.
   
   Then `cmake -DCMAKE_INSTALL_PREFIX=/tmp/mxnet ..; ninja install` will place all files that need to be packaged at the install prefix path, and the python setup.py only needs to package these files.. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org