You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/04/07 21:13:37 UTC
[GitHub] [druid] xvrl opened a new pull request #11073: remove ZooKeeper 3.4 support + pass tests with Java 15
xvrl opened a new pull request #11073:
URL: https://github.com/apache/druid/pull/11073
depends on #11074
* remove ZooKeeper 3.4.x compatibility and update netty to 4.1.63
(ZK 3.5 ships a newer netty version with additional netty dependencies)
* keep ZooKeeper version used for integration tests in sync with client library version
* add support to run integration tests with JDK 15
* build and run unit tests with Java 15 in travis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] xvrl commented on pull request #11073: Make tests pass with Java 15, remove ZooKeeper 3.4 support
Posted by GitBox <gi...@apache.org>.
xvrl commented on pull request #11073:
URL: https://github.com/apache/druid/pull/11073#issuecomment-814503116
for some reason travic-ci is not picking up this PR 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] xvrl edited a comment on pull request #11073: remove ZooKeeper 3.4 support + pass tests with Java 15
Posted by GitBox <gi...@apache.org>.
xvrl edited a comment on pull request #11073:
URL: https://github.com/apache/druid/pull/11073#issuecomment-830495264
> Can you update the docs somewhere to talk about the minimum ZK server version that we support, and the fact that it's been revved recently?
Agree, I can add something to the docs to that effect.
> Should we update Curator too?
There are a couple more breaking changes in curator 5.0, so we can deal with that separately. Additionally, it lets someone still run against ZK 3.4.x by replacing the client libraries in the classpath if needed. We can probably move to 5.x in Druid 0.23
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm commented on pull request #11073: remove ZooKeeper 3.4 support + pass tests with Java 15
Posted by GitBox <gi...@apache.org>.
gianm commented on pull request #11073:
URL: https://github.com/apache/druid/pull/11073#issuecomment-847927739
> There are a couple more breaking changes in curator 5.0, so we can deal with that separately. Additionally, it lets someone still run against ZK 3.4.x by replacing the client libraries in the classpath if needed. We can probably move to 5.x in Druid 0.23
That's a good point, it'd be nice to retain the ability for people to drop in ZK 3.4 clients for some time. Maybe even a bit beyond Druid 0.23, if the new Curator doesn't offer much exciting stuff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] xvrl commented on pull request #11073: remove ZooKeeper 3.4 support + pass tests with Java 15
Posted by GitBox <gi...@apache.org>.
xvrl commented on pull request #11073:
URL: https://github.com/apache/druid/pull/11073#issuecomment-815268494
reopening in the attempt to trigger a travis-ci build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] xvrl commented on pull request #11073: remove ZooKeeper 3.4 support + pass tests with Java 15
Posted by GitBox <gi...@apache.org>.
xvrl commented on pull request #11073:
URL: https://github.com/apache/druid/pull/11073#issuecomment-846175088
@gianm added the docs, and rebased on the latest master to fix conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] xvrl closed pull request #11073: Make tests pass with Java 15, remove ZooKeeper 3.4 support
Posted by GitBox <gi...@apache.org>.
xvrl closed pull request #11073:
URL: https://github.com/apache/druid/pull/11073
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] santosh-d3vpl3x commented on pull request #11073: remove ZooKeeper 3.4 support + pass tests with Java 15
Posted by GitBox <gi...@apache.org>.
santosh-d3vpl3x commented on pull request #11073:
URL: https://github.com/apache/druid/pull/11073#issuecomment-847696176
Is the milestone for this upgrade `0.21.x` or `0.22.x`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] xvrl closed pull request #11073: Make tests pass with Java 15, remove ZooKeeper 3.4 support
Posted by GitBox <gi...@apache.org>.
xvrl closed pull request #11073:
URL: https://github.com/apache/druid/pull/11073
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] xvrl edited a comment on pull request #11073: Make tests pass with Java 15, remove ZooKeeper 3.4 support
Posted by GitBox <gi...@apache.org>.
xvrl edited a comment on pull request #11073:
URL: https://github.com/apache/druid/pull/11073#issuecomment-814503116
for some reason travis-ci is not picking up this PR 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] xvrl merged pull request #11073: remove ZooKeeper 3.4 support + pass tests with Java 15
Posted by GitBox <gi...@apache.org>.
xvrl merged pull request #11073:
URL: https://github.com/apache/druid/pull/11073
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] xvrl commented on pull request #11073: remove ZooKeeper 3.4 support + pass tests with Java 15
Posted by GitBox <gi...@apache.org>.
xvrl commented on pull request #11073:
URL: https://github.com/apache/druid/pull/11073#issuecomment-830495264
> Can you update the docs somewhere to talk about the minimum ZK server version that we support, and the fact that it's been revved recently?
Agree, I can add something to the docs to that effect.
> Should we update Curator too?
There are a couple more breaking changes in curator 5.0, so we can deal with that separately. Additionally, it lets someone still run against ZK 3.4.x by replacing the client libraries in the classpath if needed. We can probably move to 5.x in Druid 0.23
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org