You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/04 07:43:40 UTC
[GitHub] [flink-connector-elasticsearch] zentol commented on a diff in pull request #15: [FLINK-27475][Build] Clean-up unused Maven dependencies, plugins and profiles
zentol commented on code in PR #15:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/15#discussion_r864533814
##########
pom.xml:
##########
@@ -1314,132 +862,30 @@ under the License.
<exclude>docs/static/font-awesome/**</exclude>
<exclude>docs/static/flink-header-logo.svg</exclude>
<exclude>docs/static/figs/*.svg</exclude>
Review Comment:
```suggestion
```
##########
pom.xml:
##########
@@ -1314,132 +862,30 @@ under the License.
<exclude>docs/static/font-awesome/**</exclude>
<exclude>docs/static/flink-header-logo.svg</exclude>
<exclude>docs/static/figs/*.svg</exclude>
- <exclude>flink-clients/src/main/resources/web-docs/js/*d3.js</exclude>
<!-- the licenses that are re-bundled -->
<exclude>**/packaged_licenses/LICENSE.*.txt</exclude>
<exclude>**/licenses/LICENSE*</exclude>
<exclude>**/licenses-binary/LICENSE*</exclude>
Review Comment:
```suggestion
```
##########
pom.xml:
##########
@@ -1083,55 +680,6 @@ under the License.
</build>
</profile>
- <profile>
- <!-- Kept for backwards compatiblity, the doc buildbot expects
- this profile to exist.-->
- <id>aggregate-scaladoc</id>
- </profile>
-
-
- <profile>
- <!-- used for SNAPSHOT and regular releases -->
- <id>docs-and-source</id>
Review Comment:
Do not intend to publish javadocs? (And if so, how shall we integrate them into the docs?)
##########
pom.xml:
##########
@@ -1314,132 +862,30 @@ under the License.
<exclude>docs/static/font-awesome/**</exclude>
<exclude>docs/static/flink-header-logo.svg</exclude>
<exclude>docs/static/figs/*.svg</exclude>
- <exclude>flink-clients/src/main/resources/web-docs/js/*d3.js</exclude>
<!-- the licenses that are re-bundled -->
<exclude>**/packaged_licenses/LICENSE.*.txt</exclude>
<exclude>**/licenses/LICENSE*</exclude>
<exclude>**/licenses-binary/LICENSE*</exclude>
- <!-- web dashboard config JSON files -->
- <exclude>flink-runtime-web/web-dashboard/package.json</exclude>
- <exclude>flink-runtime-web/web-dashboard/package-lock.json</exclude>
- <exclude>flink-runtime-web/web-dashboard/angular.json</exclude>
- <exclude>flink-runtime-web/web-dashboard/proxy.conf.json</exclude>
- <exclude>flink-runtime-web/web-dashboard/tsconfig.json</exclude>
- <exclude>flink-runtime-web/web-dashboard/tslint.json</exclude>
- <exclude>flink-runtime-web/web-dashboard/src/browserslist</exclude>
- <exclude>flink-runtime-web/web-dashboard/src/tsconfig.app.json</exclude>
- <exclude>flink-runtime-web/web-dashboard/src/tsconfig.spec.json</exclude>
- <exclude>flink-runtime-web/web-dashboard/src/tslint.json</exclude>
-
- <!-- web dashboard non-binary assets -->
- <exclude>flink-runtime-web/web-dashboard/src/assets/**</exclude>
-
- <!-- generated contents -->
- <exclude>flink-runtime-web/web-dashboard/web/**</exclude>
-
- <!-- downloaded and generated web libraries. -->
- <exclude>flink-runtime-web/web-dashboard/node_modules/**</exclude>
- <exclude>flink-runtime-web/web-dashboard/node/**</exclude>
-
- <!-- antlr grammar files -->
- <exclude>flink-table/flink-table-code-splitter/src/main/antlr4/**</exclude>
-
<!-- Test Data. -->
<exclude>**/src/test/resources/*-data</exclude>
- <exclude>flink-tests/src/test/resources/testdata/terainput.txt</exclude>
- <exclude>flink-formats/flink-avro/src/test/resources/flink_11-kryo_registrations</exclude>
- <exclude>flink-scala/src/test/resources/flink_11-kryo_registrations</exclude>
- <exclude>flink-core/src/test/resources/kryo-serializer-config-snapshot-v1</exclude>
- <exclude>flink-formats/flink-avro/src/test/resources/avro/*.avsc</exclude>
<exclude>out/test/flink-avro/avro/user.avsc</exclude>
- <exclude>flink-table/flink-sql-client/src/test/resources/*.out</exclude>
- <exclude>flink-table/flink-table-planner/src/test/resources/**/*.out</exclude>
- <exclude>flink-table/flink-table-planner/src/test/resources/json/*.json</exclude>
- <exclude>flink-yarn/src/test/resources/krb5.keytab</exclude>
- <exclude>flink-end-to-end-tests/test-scripts/test-data/**</exclude>
- <exclude>flink-end-to-end-tests/test-scripts/docker-hadoop-secure-cluster/config/keystore.jks</exclude>
- <exclude>flink-connectors/flink-connector-kafka/src/test/resources/**</exclude>
- <exclude>flink-connectors/flink-connector-hive/src/test/resources/**</exclude>
- <exclude>flink-end-to-end-tests/flink-tpcds-test/tpcds-tool/answer_set/*</exclude>
- <exclude>flink-end-to-end-tests/flink-tpcds-test/tpcds-tool/query/*</exclude>
- <exclude>flink-connectors/flink-connector-aws-base/src/test/resources/profile</exclude>
- <exclude>flink-connectors/flink-connector-kinesis/src/test/resources/profile</exclude>
- <exclude>flink-connectors/flink-connector-aws-kinesis-streams/src/test/resources/profile</exclude>
- <exclude>flink-table/flink-table-code-splitter/src/test/resources/**</exclude>
- <exclude>flink-connectors/flink-connector-pulsar/src/test/resources/**</exclude>
<!-- ArchUnit violation stores -->
<exclude>**/archunit-violations/**</exclude>
- <!-- snapshots -->
- <exclude>**/src/test/resources/serializer-snapshot-*</exclude>
- <exclude>**/src/test/resources/**/serializer-snapshot</exclude>
- <exclude>**/src/test/resources/**/test-data</exclude>
- <exclude>**/src/test/resources/*-snapshot</exclude>
- <exclude>**/src/test/resources/*.snapshot</exclude>
- <exclude>**/src/test/resources/*-savepoint/**</exclude>
- <exclude>**/src/test/resources/*-savepoint-native/**</exclude>
- <exclude>**/src/test/resources/*-checkpoint/**</exclude>
- <exclude>flink-core/src/test/resources/serialized-kryo-serializer-1.3</exclude>
- <exclude>flink-core/src/test/resources/type-without-avro-serialized-using-kryo</exclude>
- <exclude>flink-formats/flink-avro/src/test/resources/flink-1.4-serializer-java-serialized</exclude>
-
- <exclude>flink-end-to-end-tests/flink-state-evolution-test/src/main/java/org/apache/flink/avro/generated/*</exclude>
- <exclude>flink-end-to-end-tests/flink-state-evolution-test/savepoints/*</exclude>
- <exclude>flink-formats/flink-avro/src/test/resources/testdata.avro</exclude>
- <exclude>flink-formats/flink-avro/src/test/java/org/apache/flink/formats/avro/generated/*.java</exclude>
- <exclude>flink-formats/flink-avro-confluent-registry/src/test/resources/*.json</exclude>
- <exclude>flink-formats/flink-avro-confluent-registry/src/test/resources/*.avro</exclude>
- <exclude>flink-formats/flink-json/src/test/resources/*.txt</exclude>
- <exclude>flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/generated/*.java</exclude>
- <exclude>flink-formats/flink-parquet/src/test/resources/avro/**</exclude>
- <exclude>flink-formats/flink-parquet/src/test/resources/protobuf/**</exclude>
- <!-- netty test file, still Apache License 2.0 but with a different header -->
- <exclude>flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/AbstractByteBufTest.java</exclude>
- <!-- Configuration Files. -->
- <exclude>**/flink-bin/conf/workers</exclude>
- <exclude>**/flink-bin/conf/masters</exclude>
<!-- Administrative files in the main trunk. -->
<exclude>**/README.md</exclude>
<exclude>.github/**</exclude>
<!-- Build files -->
<exclude>**/*.iml</exclude>
- <exclude>flink-quickstart/**/testArtifact/goal.txt</exclude>
<!-- Generated content -->
<exclude>out/**</exclude>
<exclude>**/target/**</exclude>
<exclude>**/scalastyle-output.xml</exclude>
Review Comment:
```suggestion
```
##########
pom.xml:
##########
@@ -1314,132 +862,30 @@ under the License.
<exclude>docs/static/font-awesome/**</exclude>
<exclude>docs/static/flink-header-logo.svg</exclude>
<exclude>docs/static/figs/*.svg</exclude>
Review Comment:
there are more above that can also be removed.
##########
pom.xml:
##########
@@ -1945,122 +1311,6 @@ under the License.
</executions>
</plugin>
- <!-- configure scala style -->
- <plugin>
- <groupId>org.scalastyle</groupId>
- <artifactId>scalastyle-maven-plugin</artifactId>
- <version>1.0.0</version>
- <executions>
- <execution>
- <phase>validate</phase>
- <goals>
- <goal>check</goal>
- </goals>
- </execution>
- </executions>
- <configuration>
- <verbose>false</verbose>
- <failOnViolation>true</failOnViolation>
- <includeTestSourceDirectory>true</includeTestSourceDirectory>
- <failOnWarning>false</failOnWarning>
- <sourceDirectory>${basedir}/src/main/scala</sourceDirectory>
- <testSourceDirectory>${basedir}/src/test/scala</testSourceDirectory>
- <outputFile>${project.basedir}/target/scalastyle-output.xml</outputFile>
- <inputEncoding>UTF-8</inputEncoding>
- <outputEncoding>UTF-8</outputEncoding>
- </configuration>
- </plugin>
-
- <!-- set scala maven plugin version -->
- <plugin>
- <groupId>net.alchim31.maven</groupId>
- <artifactId>scala-maven-plugin</artifactId>
- <version>3.2.2</version>
- <configuration>
- <args>
- <arg>-nobootcp</arg>
- <arg>-target:jvm-${target.java.version}</arg>
- </args>
- <jvmArgs>
- <arg>-Xss2m</arg>
- </jvmArgs>
- </configuration>
- </plugin>
-
- <!-- Configuration for the binary compatibility checker -->
- <plugin>
- <groupId>com.github.siom79.japicmp</groupId>
- <artifactId>japicmp-maven-plugin</artifactId>
Review Comment:
a bit strange that this is removed.
##########
pom.xml:
##########
@@ -1945,122 +1311,6 @@ under the License.
</executions>
</plugin>
- <!-- configure scala style -->
- <plugin>
- <groupId>org.scalastyle</groupId>
- <artifactId>scalastyle-maven-plugin</artifactId>
- <version>1.0.0</version>
- <executions>
- <execution>
- <phase>validate</phase>
- <goals>
- <goal>check</goal>
- </goals>
- </execution>
- </executions>
- <configuration>
- <verbose>false</verbose>
- <failOnViolation>true</failOnViolation>
- <includeTestSourceDirectory>true</includeTestSourceDirectory>
- <failOnWarning>false</failOnWarning>
- <sourceDirectory>${basedir}/src/main/scala</sourceDirectory>
- <testSourceDirectory>${basedir}/src/test/scala</testSourceDirectory>
- <outputFile>${project.basedir}/target/scalastyle-output.xml</outputFile>
- <inputEncoding>UTF-8</inputEncoding>
- <outputEncoding>UTF-8</outputEncoding>
- </configuration>
- </plugin>
-
- <!-- set scala maven plugin version -->
- <plugin>
- <groupId>net.alchim31.maven</groupId>
- <artifactId>scala-maven-plugin</artifactId>
- <version>3.2.2</version>
- <configuration>
- <args>
- <arg>-nobootcp</arg>
- <arg>-target:jvm-${target.java.version}</arg>
- </args>
- <jvmArgs>
- <arg>-Xss2m</arg>
- </jvmArgs>
- </configuration>
- </plugin>
-
- <!-- Configuration for the binary compatibility checker -->
- <plugin>
- <groupId>com.github.siom79.japicmp</groupId>
- <artifactId>japicmp-maven-plugin</artifactId>
- <version>0.11.0</version>
- <configuration>
- <oldVersion>
- <dependency>
- <groupId>org.apache.flink</groupId>
- <artifactId>${project.artifactId}</artifactId>
- <version>${japicmp.referenceVersion}</version>
- <type>${project.packaging}</type>
- </dependency>
- </oldVersion>
- <newVersion>
- <file>
- <path>${project.build.directory}/${project.artifactId}-${project.version}.${project.packaging}</path>
- </file>
- </newVersion>
- <parameter>
- <onlyModified>true</onlyModified>
- <includes>
- <include>@org.apache.flink.annotation.Public</include>
- <!-- The following line is un-commented by tools/releasing/update_japicmp_configuration.sh
- as part of the release process -->
- <!--<include>@org.apache.flink.annotation.PublicEvolving</include>-->
- </includes>
- <excludes>
- <exclude>@org.apache.flink.annotation.Experimental</exclude>
- <exclude>@org.apache.flink.annotation.PublicEvolving</exclude>
- <exclude>@org.apache.flink.annotation.Internal</exclude>
- <exclude>org.apache.flink.streaming.api.datastream.DataStream#DataStream(org.apache.flink.streaming.api.environment.StreamExecutionEnvironment,org.apache.flink.streaming.api.transformations.StreamTransformation)</exclude>
- <exclude>org.apache.flink.streaming.api.environment.LegacyLocalStreamEnvironment</exclude>
- <exclude>org.apache.flink.streaming.api.functions.sink.RichSinkFunction#invoke(java.lang.Object)</exclude>
- <exclude>org.apache.flink.streaming.api.functions.sink.SinkFunction</exclude>
- <exclude>org.apache.flink.api.java.hadoop.mapred.HadoopInputFormat</exclude>
- <exclude>org.apache.flink.api.java.hadoop.mapred.HadoopOutputFormat</exclude>
- <exclude>org.apache.flink.api.java.hadoop.mapreduce.HadoopInputFormat</exclude>
- <exclude>org.apache.flink.api.java.hadoop.mapreduce.HadoopOutputFormat</exclude>
- <exclude>org.apache.flink.api.scala.hadoop.mapred.HadoopInputFormat</exclude>
- <exclude>org.apache.flink.api.scala.hadoop.mapred.HadoopOutputFormat</exclude>
- <exclude>org.apache.flink.api.scala.hadoop.mapreduce.HadoopInputFormat</exclude>
- <exclude>org.apache.flink.api.scala.hadoop.mapreduce.HadoopOutputFormat</exclude>
- </excludes>
- <accessModifier>public</accessModifier>
- <breakBuildOnModifications>false</breakBuildOnModifications>
- <breakBuildOnBinaryIncompatibleModifications>true</breakBuildOnBinaryIncompatibleModifications>
- <breakBuildOnSourceIncompatibleModifications>true</breakBuildOnSourceIncompatibleModifications>
- <onlyBinaryIncompatible>false</onlyBinaryIncompatible>
- <includeSynthetic>true</includeSynthetic>
- <ignoreMissingClasses>false</ignoreMissingClasses>
- <skipPomModules>true</skipPomModules>
- <!-- Don't break build on newly added maven modules -->
- <ignoreNonResolvableArtifacts>true</ignoreNonResolvableArtifacts>
- </parameter>
- <projectBuildDir>${rootDir}/${japicmp.outputDir}/${project.artifactId}</projectBuildDir>
- <dependencies>
- <dependency>
- <groupId>org.apache.flink</groupId>
- <artifactId>flink-annotations</artifactId>
- <version>${project.version}</version>
- </dependency>
- </dependencies>
- </configuration>
- <executions>
- <execution>
- <phase>verify</phase>
- <goals>
- <goal>cmp</goal>
- </goals>
- </execution>
- </executions>
- </plugin>
-
<plugin>
<!-- run via "mvn org.owasp:dependency-check-maven:aggregate" -->
<groupId>org.owasp</groupId>
Review Comment:
this can also be removed; no one is using it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org