You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by lt...@apache.org on 2011/07/12 13:08:30 UTC

svn commit: r1145546 - in /maven/plugins/trunk/maven-site-plugin: ./ src/it/interpolation/ src/it/interpolation/parent/ src/main/java/org/apache/maven/plugins/site/

Author: ltheussl
Date: Tue Jul 12 11:08:29 2011
New Revision: 1145546

URL: http://svn.apache.org/viewvc?rev=1145546&view=rev
Log:
[MSITE-585] empty deploy protocol when properties are used

Added:
    maven/plugins/trunk/maven-site-plugin/src/it/interpolation/invoker.properties
Removed:
    maven/plugins/trunk/maven-site-plugin/src/it/interpolation/goals.txt
Modified:
    maven/plugins/trunk/maven-site-plugin/pom.xml
    maven/plugins/trunk/maven-site-plugin/src/it/interpolation/parent/pom.xml
    maven/plugins/trunk/maven-site-plugin/src/it/interpolation/pom.xml
    maven/plugins/trunk/maven-site-plugin/src/it/interpolation/verify.bsh
    maven/plugins/trunk/maven-site-plugin/src/main/java/org/apache/maven/plugins/site/AbstractDeployMojo.java

Modified: maven/plugins/trunk/maven-site-plugin/pom.xml
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-site-plugin/pom.xml?rev=1145546&r1=1145545&r2=1145546&view=diff
==============================================================================
--- maven/plugins/trunk/maven-site-plugin/pom.xml (original)
+++ maven/plugins/trunk/maven-site-plugin/pom.xml Tue Jul 12 11:08:29 2011
@@ -402,10 +402,6 @@ under the License.
               <pomIncludes>
                 <pomInclude>*/pom.xml</pomInclude>
               </pomIncludes>
-              <!-- FIXME: remove! -->
-              <pomExcludes>
-                <pomInclude>interpolation/pom.xml</pomInclude>
-              </pomExcludes>
               <postBuildHookScript>verify</postBuildHookScript>
               <localRepositoryPath>${project.build.directory}/local-repo</localRepositoryPath>
               <goals>

Added: maven/plugins/trunk/maven-site-plugin/src/it/interpolation/invoker.properties
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-site-plugin/src/it/interpolation/invoker.properties?rev=1145546&view=auto
==============================================================================
--- maven/plugins/trunk/maven-site-plugin/src/it/interpolation/invoker.properties (added)
+++ maven/plugins/trunk/maven-site-plugin/src/it/interpolation/invoker.properties Tue Jul 12 11:08:29 2011
@@ -0,0 +1,2 @@
+invoker.goals.1 = clean
+invoker.goals.2 = site-deploy

Modified: maven/plugins/trunk/maven-site-plugin/src/it/interpolation/parent/pom.xml
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-site-plugin/src/it/interpolation/parent/pom.xml?rev=1145546&r1=1145545&r2=1145546&view=diff
==============================================================================
--- maven/plugins/trunk/maven-site-plugin/src/it/interpolation/parent/pom.xml (original)
+++ maven/plugins/trunk/maven-site-plugin/src/it/interpolation/parent/pom.xml Tue Jul 12 11:08:29 2011
@@ -31,6 +31,8 @@ under the License.
 
   <properties>
     <interpolated>interpolation</interpolated>
+    <site.server>site-deploy</site.server>
+    <site.repository>file://@project.build.directory@/it/${interpolated}/target/site-deployed/parent/</site.repository>
   </properties>
 
   <distributionManagement>

Modified: maven/plugins/trunk/maven-site-plugin/src/it/interpolation/pom.xml
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-site-plugin/src/it/interpolation/pom.xml?rev=1145546&r1=1145545&r2=1145546&view=diff
==============================================================================
--- maven/plugins/trunk/maven-site-plugin/src/it/interpolation/pom.xml (original)
+++ maven/plugins/trunk/maven-site-plugin/src/it/interpolation/pom.xml Tue Jul 12 11:08:29 2011
@@ -39,16 +39,6 @@ under the License.
     <site.repository>file://@project.build.directory@/it/${interpolated}/target/site-deployed/</site.repository>
   </properties>
 
-<!-- FIXME: moving the distMngmnt section from parent to here makes it work!? -->
-<!--
-  <distributionManagement>
-    <site>
-      <id>${site.server}</id>
-      <url>${site.repository}</url>
-    </site>
-  </distributionManagement>
--->
-
   <build>
     <plugins>
       <plugin>

Modified: maven/plugins/trunk/maven-site-plugin/src/it/interpolation/verify.bsh
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-site-plugin/src/it/interpolation/verify.bsh?rev=1145546&r1=1145545&r2=1145546&view=diff
==============================================================================
--- maven/plugins/trunk/maven-site-plugin/src/it/interpolation/verify.bsh (original)
+++ maven/plugins/trunk/maven-site-plugin/src/it/interpolation/verify.bsh Tue Jul 12 11:08:29 2011
@@ -29,10 +29,11 @@ try
     if ( !target.exists() || !target.isDirectory() )
     {
         System.err.println( "target file is missing or not a directory." );
+        System.err.println( target.getAbsolutePath() );
         result = false;
     }
 
-    File siteDirectory = new File( target, "site-deployed" );
+    File siteDirectory = new File( target, "site-deployed/interpolation" );
     if ( !siteDirectory.exists() || !siteDirectory.isDirectory() )
     {
         System.err.println( "site file is missing or not a directory." );
@@ -44,6 +45,7 @@ try
     if ( !index.exists() || index.isDirectory() )
     {
         System.err.println( "index.html file is missing or a directory." );
+        System.err.println( index.getAbsolutePath() );
         result = false;
     }
 }

Modified: maven/plugins/trunk/maven-site-plugin/src/main/java/org/apache/maven/plugins/site/AbstractDeployMojo.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-site-plugin/src/main/java/org/apache/maven/plugins/site/AbstractDeployMojo.java?rev=1145546&r1=1145545&r2=1145546&view=diff
==============================================================================
--- maven/plugins/trunk/maven-site-plugin/src/main/java/org/apache/maven/plugins/site/AbstractDeployMojo.java (original)
+++ maven/plugins/trunk/maven-site-plugin/src/main/java/org/apache/maven/plugins/site/AbstractDeployMojo.java Tue Jul 12 11:08:29 2011
@@ -638,7 +638,7 @@ public abstract class AbstractDeployMojo
      *
      * @throws MojoExecutionException if no site info is found in the tree.
      */
-    protected static Site getRootSite( MavenProject project )
+    protected Site getRootSite( MavenProject project )
         throws MojoExecutionException
     {
         Site site = getSite( project );
@@ -647,7 +647,8 @@ public abstract class AbstractDeployMojo
 
         while ( parent.getParent() != null )
         {
-            parent = parent.getParent();
+            // MSITE-585, MNG-1943
+            parent = siteTool.getParentProject( parent, reactorProjects, localRepository );
 
             try
             {