You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org> on 2019/11/08 22:51:52 UTC
[Impala-ASF-CR] IMPALA-9082: make WebserverTest error checking stricter
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14672
Change subject: IMPALA-9082: make WebserverTest error checking stricter
......................................................................
IMPALA-9082: make WebserverTest error checking stricter
WebserverTest::TestWithSpnego has been flaky lately, but I have been
unable to repro it. This patch is an attempt to make it easier to
debug the issue the next time it shows up in automated builds.
The test performs a GET that is expected to fail and then checks that
the metrics show the failed GET. The flaky failures occur when the
metrics do not show a failed attempt.
It appears that what's happening is the GET is failing before actually
reaching the webserver. However, because the GET is expected to fail
and because we only verify that it did fail by checking that HttpGet()
returned some error status, whatever unexpected error is occuring is
getting lost.
This patch instead checks the actual text of the error that is
returned by HttpGet() to make sure it is correct and logs the error if
it isn't.
Change-Id: I820336271cf25130538ceae2eed10a72a73d2adc
---
M be/src/testutil/gtest-util.h
M be/src/util/webserver-test.cc
2 files changed, 13 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/14672/1
--
To view, visit http://gerrit.cloudera.org:8080/14672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I820336271cf25130538ceae2eed10a72a73d2adc
Gerrit-Change-Number: 14672
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-9082: make WebserverTest error checking stricter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14672 )
Change subject: IMPALA-9082: make WebserverTest error checking stricter
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4992/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I820336271cf25130538ceae2eed10a72a73d2adc
Gerrit-Change-Number: 14672
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Nov 2019 23:37:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9082: make WebserverTest error checking stricter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14672 )
Change subject: IMPALA-9082: make WebserverTest error checking stricter
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I820336271cf25130538ceae2eed10a72a73d2adc
Gerrit-Change-Number: 14672
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Nov 2019 17:46:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9082: make WebserverTest error checking stricter
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14672 )
Change subject: IMPALA-9082: make WebserverTest error checking stricter
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I820336271cf25130538ceae2eed10a72a73d2adc
Gerrit-Change-Number: 14672
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Nov 2019 17:17:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9082: make WebserverTest error checking stricter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14672 )
Change subject: IMPALA-9082: make WebserverTest error checking stricter
......................................................................
IMPALA-9082: make WebserverTest error checking stricter
WebserverTest::TestWithSpnego has been flaky lately, but I have been
unable to repro it. This patch is an attempt to make it easier to
debug the issue the next time it shows up in automated builds.
The test performs a GET that is expected to fail and then checks that
the metrics show the failed GET. The flaky failures occur when the
metrics do not show a failed attempt.
It appears that what's happening is the GET is failing before actually
reaching the webserver. However, because the GET is expected to fail
and because we only verify that it did fail by checking that HttpGet()
returned some error status, whatever unexpected error is occuring is
getting lost.
This patch instead checks the actual text of the error that is
returned by HttpGet() to make sure it is correct and logs the error if
it isn't.
Change-Id: I820336271cf25130538ceae2eed10a72a73d2adc
Reviewed-on: http://gerrit.cloudera.org:8080/14672
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/testutil/gtest-util.h
M be/src/util/webserver-test.cc
2 files changed, 13 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I820336271cf25130538ceae2eed10a72a73d2adc
Gerrit-Change-Number: 14672
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9082: make WebserverTest error checking stricter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14672 )
Change subject: IMPALA-9082: make WebserverTest error checking stricter
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I820336271cf25130538ceae2eed10a72a73d2adc
Gerrit-Change-Number: 14672
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Nov 2019 22:18:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9082: make WebserverTest error checking stricter
Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14672 )
Change subject: IMPALA-9082: make WebserverTest error checking stricter
......................................................................
Patch Set 1: Code-Review+1
Thanks for making this change. Looks good to me.
--
To view, visit http://gerrit.cloudera.org:8080/14672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I820336271cf25130538ceae2eed10a72a73d2adc
Gerrit-Change-Number: 14672
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 09 Nov 2019 17:39:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9082: make WebserverTest error checking stricter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14672 )
Change subject: IMPALA-9082: make WebserverTest error checking stricter
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5201/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I820336271cf25130538ceae2eed10a72a73d2adc
Gerrit-Change-Number: 14672
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Nov 2019 17:46:36 +0000
Gerrit-HasComments: No