You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/06/04 22:00:46 UTC
[GitHub] [fineract] percyashu opened a new pull request #982: FINERACT-822 Enabling AssertEqualsArgumentOrderChecker check
percyashu opened a new pull request #982:
URL: https://github.com/apache/fineract/pull/982
FINERACT-822
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum merged pull request #982: FINERACT-822 Enabling AssertEqualsArgumentOrderChecker check
Posted by GitBox <gi...@apache.org>.
awasum merged pull request #982:
URL: https://github.com/apache/fineract/pull/982
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on a change in pull request #982: FINERACT-822 Enabling AssertEqualsArgumentOrderChecker check
Posted by GitBox <gi...@apache.org>.
awasum commented on a change in pull request #982:
URL: https://github.com/apache/fineract/pull/982#discussion_r435758675
##########
File path: fineract-provider/src/test/java/org/apache/fineract/notification/StorageTest.java
##########
@@ -126,7 +126,7 @@ public void testNotificationStorage() {
verify(this.notificationGeneratorWritePlatformService, times(1)).create(refEq(notification, "createdAt"));
verify(this.notificationMapperWritePlatformService, times(1)).create(refEq(notificationMapper, "createdAt"));
verify(this.notificationGeneratorReadRepositoryWrapper, times(1)).findById(1L);
- assertEquals(actualGeneratedNotificationId, Long.valueOf(1));
+ assertEquals(Long.valueOf(1),actualGeneratedNotificationId);
Review comment:
Is there a need for a space here? I will just merge this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] percyashu commented on a change in pull request #982: FINERACT-822 Enabling AssertEqualsArgumentOrderChecker check
Posted by GitBox <gi...@apache.org>.
percyashu commented on a change in pull request #982:
URL: https://github.com/apache/fineract/pull/982#discussion_r435711544
##########
File path: fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/AccountNumberPreferencesTest.java
##########
@@ -376,7 +376,7 @@ private void validateAccountNumberLengthAndStartsWithPrefix(final String account
Assert.assertEquals(accountNumber.length(), prefix.length() + 9);
Assert.assertTrue(accountNumber.startsWith(prefix));
} else {
- Assert.assertEquals(accountNumber.length(), 9);
+ Assert.assertEquals( 9,accountNumber.length());
Review comment:
Ok done that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] xurror commented on a change in pull request #982: FINERACT-822 Enabling AssertEqualsArgumentOrderChecker check
Posted by GitBox <gi...@apache.org>.
xurror commented on a change in pull request #982:
URL: https://github.com/apache/fineract/pull/982#discussion_r435682753
##########
File path: fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/AccountNumberPreferencesTest.java
##########
@@ -376,7 +376,7 @@ private void validateAccountNumberLengthAndStartsWithPrefix(final String account
Assert.assertEquals(accountNumber.length(), prefix.length() + 9);
Assert.assertTrue(accountNumber.startsWith(prefix));
} else {
- Assert.assertEquals(accountNumber.length(), 9);
+ Assert.assertEquals( 9,accountNumber.length());
Review comment:
Does this stuff also reject space separated commas. It's not a big deal I'd prefer if there is a space after the comma. Makes stuff more readable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] percyashu commented on pull request #982: FINERACT-822 Enabling AssertEqualsArgumentOrderChecker check
Posted by GitBox <gi...@apache.org>.
percyashu commented on pull request #982:
URL: https://github.com/apache/fineract/pull/982#issuecomment-639153931
@xurror @awasum @vorburger LGTY?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org