You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hugegraph.apache.org by GitBox <gi...@apache.org> on 2022/04/19 10:42:33 UTC

[GitHub] [incubator-hugegraph] seagle-yuan opened a new pull request, #1833: improve ClassTypeParameterName check

seagle-yuan opened a new pull request, #1833:
URL: https://github.com/apache/incubator-hugegraph/pull/1833

   improve ClassTypeParameterName check
   the regular expression of "ClassTypeParameterName " 
   from "(^[A-Z][0-9]?)$|([A-Z][a-zA-Z0-9]*[T]$)" to "[A-Z][a-zA-Z0-9]*$"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-hugegraph] codecov[bot] commented on pull request #1833: improve ClassTypeParameterName check

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #1833:
URL: https://github.com/apache/incubator-hugegraph/pull/1833#issuecomment-1104932720

   # [Codecov](https://codecov.io/gh/apache/incubator-hugegraph/pull/1833?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1833](https://codecov.io/gh/apache/incubator-hugegraph/pull/1833?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (183a8b2) into [master](https://codecov.io/gh/apache/incubator-hugegraph/commit/28ed873360c5c3c8fd6e638c6c31417ae3d982a8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (28ed873) will **increase** coverage by `0.37%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1833      +/-   ##
   ============================================
   + Coverage     66.56%   66.94%   +0.37%     
   + Complexity      980      444     -536     
   ============================================
     Files           446      446              
     Lines         37955    37955              
     Branches       5410     5410              
   ============================================
   + Hits          25266    25409     +143     
   + Misses         9983     9950      -33     
   + Partials       2706     2596     -110     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-hugegraph/pull/1833?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...egraph/backend/store/scylladb/ScyllaDBMetrics.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1833/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLXNjeWxsYWRiL3NyYy9tYWluL2phdmEvY29tL2JhaWR1L2h1Z2VncmFwaC9iYWNrZW5kL3N0b3JlL3NjeWxsYWRiL1NjeWxsYURCTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...graph/backend/store/scylladb/ScyllaDBFeatures.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1833/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLXNjeWxsYWRiL3NyYy9tYWluL2phdmEvY29tL2JhaWR1L2h1Z2VncmFwaC9iYWNrZW5kL3N0b3JlL3NjeWxsYWRiL1NjeWxsYURCRmVhdHVyZXMuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ackend/store/cassandra/CassandraStoreProvider.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1833/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNhc3NhbmRyYS9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvYmFja2VuZC9zdG9yZS9jYXNzYW5kcmEvQ2Fzc2FuZHJhU3RvcmVQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../backend/store/scylladb/ScyllaDBStoreProvider.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1833/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLXNjeWxsYWRiL3NyYy9tYWluL2phdmEvY29tL2JhaWR1L2h1Z2VncmFwaC9iYWNrZW5kL3N0b3JlL3NjeWxsYWRiL1NjeWxsYURCU3RvcmVQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-97.30%)` | :arrow_down: |
   | [...h/backend/store/scylladb/ScyllaDBTablesWithMV.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1833/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLXNjeWxsYWRiL3NyYy9tYWluL2phdmEvY29tL2JhaWR1L2h1Z2VncmFwaC9iYWNrZW5kL3N0b3JlL3NjeWxsYWRiL1NjeWxsYURCVGFibGVzV2l0aE1WLmphdmE=) | `0.00% <0.00%> (-96.04%)` | :arrow_down: |
   | [...h/backend/store/cassandra/CassandraSerializer.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1833/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNhc3NhbmRyYS9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvYmFja2VuZC9zdG9yZS9jYXNzYW5kcmEvQ2Fzc2FuZHJhU2VyaWFsaXplci5qYXZh) | `0.00% <0.00%> (-91.57%)` | :arrow_down: |
   | [...graph/backend/store/cassandra/CassandraTables.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1833/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNhc3NhbmRyYS9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvYmFja2VuZC9zdG9yZS9jYXNzYW5kcmEvQ2Fzc2FuZHJhVGFibGVzLmphdmE=) | `0.00% <0.00%> (-89.11%)` | :arrow_down: |
   | [...raph/backend/store/cassandra/CassandraMetrics.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1833/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNhc3NhbmRyYS9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvYmFja2VuZC9zdG9yZS9jYXNzYW5kcmEvQ2Fzc2FuZHJhTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-86.96%)` | :arrow_down: |
   | [...com/datastax/driver/core/querybuilder/Clauses.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1833/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNhc3NhbmRyYS9zcmMvbWFpbi9qYXZhL2NvbS9kYXRhc3RheC9kcml2ZXIvY29yZS9xdWVyeWJ1aWxkZXIvQ2xhdXNlcy5qYXZh) | `0.00% <0.00%> (-83.34%)` | :arrow_down: |
   | [...ackend/store/cassandra/CassandraEntryIterator.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1833/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNhc3NhbmRyYS9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvYmFja2VuZC9zdG9yZS9jYXNzYW5kcmEvQ2Fzc2FuZHJhRW50cnlJdGVyYXRvci5qYXZh) | `0.00% <0.00%> (-82.61%)` | :arrow_down: |
   | ... and [131 more](https://codecov.io/gh/apache/incubator-hugegraph/pull/1833/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hugegraph/pull/1833?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-hugegraph/pull/1833?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [28ed873...183a8b2](https://codecov.io/gh/apache/incubator-hugegraph/pull/1833?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-hugegraph] seagle-yuan commented on pull request #1833: improve ClassTypeParameterName check

Posted by GitBox <gi...@apache.org>.
seagle-yuan commented on PR #1833:
URL: https://github.com/apache/incubator-hugegraph/pull/1833#issuecomment-1106490024

   can you help me reopen ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-hugegraph] imbajin commented on pull request #1833: improve ClassTypeParameterName check

Posted by GitBox <gi...@apache.org>.
imbajin commented on PR #1833:
URL: https://github.com/apache/incubator-hugegraph/pull/1833#issuecomment-1102501249

   Due to CI has some troubles now, we could add more commit then wait for it 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-hugegraph] javeme commented on pull request #1833: improve ClassTypeParameterName check

Posted by GitBox <gi...@apache.org>.
javeme commented on PR #1833:
URL: https://github.com/apache/incubator-hugegraph/pull/1833#issuecomment-1108313784

   please update the latest code:
   ```bash
   git remote add apache https://github.com/apache/incubator-hugegraph
   git checkout master
   git pull apache
   git checkout checkstyle-check
   git merge master
   git push
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-hugegraph] seagle-yuan closed pull request #1833: improve ClassTypeParameterName check

Posted by GitBox <gi...@apache.org>.
seagle-yuan closed pull request #1833: improve ClassTypeParameterName check
URL: https://github.com/apache/incubator-hugegraph/pull/1833


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-hugegraph] javeme commented on pull request #1833: improve ClassTypeParameterName check

Posted by GitBox <gi...@apache.org>.
javeme commented on PR #1833:
URL: https://github.com/apache/incubator-hugegraph/pull/1833#issuecomment-1106106686

   ci errors with cassandra backend:
   ```java
   [INFO] Running com.baidu.hugegraph.api.ApiTestSuite
   Error:  Tests run: 86, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 54.335 s <<< FAILURE! - in com.baidu.hugegraph.api.ApiTestSuite
   Error:  testMetricsBackend(com.baidu.hugegraph.api.MetricsApiTest)  Time elapsed: 0.113 s  <<< FAILURE!
   java.lang.AssertionError: Expect contains key 'mem_max' in {exception=java.io.IOException: Failed to retrieve RMIServer stub: javax.naming.InvalidNameException: Malformed IPv6 address at index 7: rmi://[127.0.0.1]:7199 [Root exception is java.lang.IllegalArgumentException: Malformed IPv6 address at index 7: rmi://[127.0.0.1]:7199]}
   	at com.baidu.hugegraph.api.MetricsApiTest.testMetricsBackend(MetricsApiTest.java:173)
   
   [INFO] 
   [INFO] Results:
   [INFO] 
   Error:  Failures: 
   Error:    MetricsApiTest.testMetricsBackend:173->BaseApiTest.assertMapContains:631 Expect contains key 'mem_max' in {exception=java.io.IOException: Failed to retrieve RMIServer stub: javax.naming.InvalidNameException: Malformed IPv6 address at index 7: rmi://[127.0.0.1]:7199 [Root exception is java.lang.IllegalArgumentException: Malformed IPv6 address at index 7: rmi://[127.0.0.1]:7199]}
   [INFO] 
   Error:  Tests run: 86, Failures: 1, Errors: 0, Skipped: 0
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-hugegraph] seagle-yuan commented on pull request #1833: improve ClassTypeParameterName check

Posted by GitBox <gi...@apache.org>.
seagle-yuan commented on PR #1833:
URL: https://github.com/apache/incubator-hugegraph/pull/1833#issuecomment-1108304910

   recheck


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-hugegraph] seagle-yuan commented on pull request #1833: improve ClassTypeParameterName check

Posted by GitBox <gi...@apache.org>.
seagle-yuan commented on PR #1833:
URL: https://github.com/apache/incubator-hugegraph/pull/1833#issuecomment-1108514262

   remove to #1850 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-hugegraph] seagle-yuan commented on pull request #1833: improve ClassTypeParameterName check

Posted by GitBox <gi...@apache.org>.
seagle-yuan commented on PR #1833:
URL: https://github.com/apache/incubator-hugegraph/pull/1833#issuecomment-1104687720

   rerun failed jobs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-hugegraph] seagle-yuan commented on pull request #1833: improve ClassTypeParameterName check

Posted by GitBox <gi...@apache.org>.
seagle-yuan commented on PR #1833:
URL: https://github.com/apache/incubator-hugegraph/pull/1833#issuecomment-1105920343

   It seems like that we can't pass the test. 
   ![1](https://user-images.githubusercontent.com/13429553/164579917-3065dc04-48ec-446d-9fec-9e9c76cb3327.JPG)
   ![2](https://user-images.githubusercontent.com/13429553/164579926-6978dc33-52b0-4850-aa15-d5343d135879.JPG)
   ![3](https://user-images.githubusercontent.com/13429553/164579928-8db029a2-d95f-4d77-ad58-6772a5f1067c.JPG)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-hugegraph] imbajin commented on pull request #1833: improve ClassTypeParameterName check

Posted by GitBox <gi...@apache.org>.
imbajin commented on PR #1833:
URL: https://github.com/apache/incubator-hugegraph/pull/1833#issuecomment-1105964628

   > It seems like that we can't pass the test. ![1](https://user-images.githubusercontent.com/13429553/164579917-3065dc04-48ec-446d-9fec-9e9c76cb3327.JPG) ![2](https://user-images.githubusercontent.com/13429553/164579926-6978dc33-52b0-4850-aa15-d5343d135879.JPG) ![3](https://user-images.githubusercontent.com/13429553/164579928-8db029a2-d95f-4d77-ad58-6772a5f1067c.JPG)
   
   seems it was a bug, submit a new bug issue to solve it maybe (the master branch also have this problem)
   
   <img width="745" alt="image" src="https://user-images.githubusercontent.com/17706099/164590174-2cde4255-dd62-4a0f-bf7c-35756284a847.png">
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-hugegraph] seagle-yuan commented on pull request #1833: improve ClassTypeParameterName check

Posted by GitBox <gi...@apache.org>.
seagle-yuan commented on PR #1833:
URL: https://github.com/apache/incubator-hugegraph/pull/1833#issuecomment-1106341537

   > 
   
   how to fix this issue.
   i want to fix this issue as quickly as possible 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org