You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jeff Coffler <je...@taltos.com> on 2018/02/12 23:31:49 UTC
Review Request 65618: Windows: Enabled `curl` and `hadoop` fetcher
plugins on Windows.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65618/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer and John Kordich.
Bugs: MESOS-6715
https://issues.apache.org/jira/browse/MESOS-6715
Repository: mesos
Description
-------
Enabled both `curl` and `hadoop` fetcher plugins on Windows platform.
Diffs
-----
src/uri/fetcher.hpp 2b2b14ec0324d4d4dc12ac9c99fd74708fc83065
src/uri/fetcher.cpp 13c2d5499b6c551e1333a73e8473de308e6c3bc2
Diff: https://reviews.apache.org/r/65618/diff/1/
Testing
-------
Thanks,
Jeff Coffler
Re: Review Request 65618: Windows: Enabled `curl` and `hadoop` fetcher
plugins on Windows.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65618/#review197332
-----------------------------------------------------------
src/uri/fetcher.hpp
Lines 40-49 (original), 40-50 (patched)
<https://reviews.apache.org/r/65618/#comment277471>
```
class Flags :
public virtual CopyFetcherPlugin::Flags,
public virtual CurlFetcherPlugin::Flags,
#ifdef __WINDOWS__
public virtual HadoopFetcherPlugin::Flags {};
#else
// TODO(coffler): Add support for Docker plugins. See MESOS-5473.
public virtual HadoopFetcherPlugin::Flags,
public virtual DockerFetcherPlugin::Flags {};
#endif // __WINDOWS__
```
src/uri/fetcher.cpp
Lines 56 (patched)
<https://reviews.apache.org/r/65618/#comment277472>
s/dpravat/coffler
src/uri/fetcher.cpp
Lines 56 (patched)
<https://reviews.apache.org/r/65618/#comment277473>
s/dpravat/coffler
- Andrew Schwartzmeyer
On Feb. 12, 2018, 3:31 p.m., Jeff Coffler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65618/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2018, 3:31 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and John Kordich.
>
>
> Bugs: MESOS-6715
> https://issues.apache.org/jira/browse/MESOS-6715
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enabled both `curl` and `hadoop` fetcher plugins on Windows platform.
>
>
> Diffs
> -----
>
> src/uri/fetcher.hpp 2b2b14ec0324d4d4dc12ac9c99fd74708fc83065
> src/uri/fetcher.cpp 13c2d5499b6c551e1333a73e8473de308e6c3bc2
>
>
> Diff: https://reviews.apache.org/r/65618/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jeff Coffler
>
>
Re: Review Request 65618: Windows: Enabled `curl` and `hadoop` fetcher
plugins on Windows.
Posted by Jeff Coffler <je...@taltos.com>.
> On Feb. 13, 2018, 12:08 a.m., Andrew Schwartzmeyer wrote:
> > I looked at MESOS-5473, and I had previously closed it because it didn't make sense.
> >
> > Would you open a new issue: "Enable Docker fetcher plugin on Windows" and update the comments here?
Done, MESOS-8570: Enable Docker fetcher plugin on Windows.
- Jeff
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65618/#review197335
-----------------------------------------------------------
On Feb. 12, 2018, 11:31 p.m., Jeff Coffler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65618/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2018, 11:31 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and John Kordich.
>
>
> Bugs: MESOS-6715
> https://issues.apache.org/jira/browse/MESOS-6715
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enabled both `curl` and `hadoop` fetcher plugins on Windows platform.
>
>
> Diffs
> -----
>
> src/uri/fetcher.hpp 2b2b14ec0324d4d4dc12ac9c99fd74708fc83065
> src/uri/fetcher.cpp 13c2d5499b6c551e1333a73e8473de308e6c3bc2
>
>
> Diff: https://reviews.apache.org/r/65618/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jeff Coffler
>
>
Re: Review Request 65618: Windows: Enabled `curl` and `hadoop` fetcher
plugins on Windows.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65618/#review197335
-----------------------------------------------------------
I looked at MESOS-5473, and I had previously closed it because it didn't make sense.
Would you open a new issue: "Enable Docker fetcher plugin on Windows" and update the comments here?
- Andrew Schwartzmeyer
On Feb. 12, 2018, 3:31 p.m., Jeff Coffler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65618/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2018, 3:31 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and John Kordich.
>
>
> Bugs: MESOS-6715
> https://issues.apache.org/jira/browse/MESOS-6715
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enabled both `curl` and `hadoop` fetcher plugins on Windows platform.
>
>
> Diffs
> -----
>
> src/uri/fetcher.hpp 2b2b14ec0324d4d4dc12ac9c99fd74708fc83065
> src/uri/fetcher.cpp 13c2d5499b6c551e1333a73e8473de308e6c3bc2
>
>
> Diff: https://reviews.apache.org/r/65618/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jeff Coffler
>
>
Re: Review Request 65618: Windows: Enabled `curl` and `hadoop` fetcher
plugins on Windows.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65618/#review197357
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Schwartzmeyer
On Feb. 12, 2018, 4:59 p.m., Jeff Coffler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65618/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2018, 4:59 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and John Kordich.
>
>
> Bugs: MESOS-6715
> https://issues.apache.org/jira/browse/MESOS-6715
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enabled both `curl` and `hadoop` fetcher plugins on Windows platform.
>
>
> Diffs
> -----
>
> src/uri/fetcher.hpp 2b2b14ec0324d4d4dc12ac9c99fd74708fc83065
> src/uri/fetcher.cpp 13c2d5499b6c551e1333a73e8473de308e6c3bc2
>
>
> Diff: https://reviews.apache.org/r/65618/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jeff Coffler
>
>
Re: Review Request 65618: Windows: Enabled `curl` and `hadoop` fetcher
plugins on Windows.
Posted by Jeff Coffler <je...@taltos.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65618/
-----------------------------------------------------------
(Updated Feb. 13, 2018, 12:59 a.m.)
Review request for mesos, Andrew Schwartzmeyer and John Kordich.
Bugs: MESOS-6715
https://issues.apache.org/jira/browse/MESOS-6715
Repository: mesos
Description
-------
Enabled both `curl` and `hadoop` fetcher plugins on Windows platform.
Diffs (updated)
-----
src/uri/fetcher.hpp 2b2b14ec0324d4d4dc12ac9c99fd74708fc83065
src/uri/fetcher.cpp 13c2d5499b6c551e1333a73e8473de308e6c3bc2
Diff: https://reviews.apache.org/r/65618/diff/2/
Changes: https://reviews.apache.org/r/65618/diff/1-2/
Testing
-------
Thanks,
Jeff Coffler