You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2022/03/04 10:11:45 UTC

[GitHub] [activemq] ilyesAj opened a new pull request #791: add the capability to override memory options

ilyesAj opened a new pull request #791:
URL: https://github.com/apache/activemq/pull/791


   since the last release , the xmx and xms are hardcoded on `env` , the goal is to use ACTIVEMQ_OPTS_MEMORY environement variable if needed to override memory options


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq] cshannon commented on pull request #791: add the capability to override memory options

Posted by GitBox <gi...@apache.org>.
cshannon commented on pull request #791:
URL: https://github.com/apache/activemq/pull/791#issuecomment-1059428374


   Looks like this was changed here: https://github.com/apache/activemq/commit/a767bda603119387af8e8ce06af268470fe33c3a
   
   The Xms change made sense (going lower) but obviously dropping that If statement is an issue. So been broken for a while but we should change it back to allow overriding.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq] cshannon commented on pull request #791: add the capability to override memory options

Posted by GitBox <gi...@apache.org>.
cshannon commented on pull request #791:
URL: https://github.com/apache/activemq/pull/791#issuecomment-1059425517


   Thanks for the PR, this seems reasonable to me, would you be able to create a Jira for this and include the Jira number in the commit to track the change? https://issues.apache.org/jira/projects/AMQ


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq] jbonofre merged pull request #791: add the capability to override memory options

Posted by GitBox <gi...@apache.org>.
jbonofre merged pull request #791:
URL: https://github.com/apache/activemq/pull/791


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org