[jira] Updated: (MAPREDUCE-1607) Task controller may not set permissions for a task cleanup attempt's log directory

["Vinod K V (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/MAPREDUCE-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod K V updated MAPREDUCE-1607:
---------------------------------

    Status: Open  (was: Patch Available)

Patch is not applying cleanly anymore to trunk:  Minor merges are needed in Application.java and TestTaskTrackerLocalization

I manually merged the patch myself to continue with the review. Mostly looks good except the following:
 - TaskRunner.java#setupLog4j(): level should not be INFO, but getLogLevel(conf).toString()
 - Tasklogservlet: The check haveTaskLog() for bypassing SYSLOG in tests will lead to missing log files from webui in case of JVMReuse. We should not do this.
 - Convert TestJvmReuse into junit 4 testcase?

Canceling patch so as to include above comments.

> Task controller may not set permissions for a task cleanup attempt's log directory
> ----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1607
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1607
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: task-controller
>    Affects Versions: 0.21.0
>            Reporter: Hemanth Yamijala
>            Assignee: Amareshwari Sriramadasu
>             Fix For: 0.21.0
>
>         Attachments: patch-1607-1.txt, patch-1607-ydist.txt, patch-1607.txt
>
>
> Task controller uses the INITIALIZE_TASK command to initialize task attempt and task log directories. For cleanup tasks, task attempt directories are named as task-attempt-id.cleanup. But log directories do not have the .cleanup suffix. The task controller is not aware of this distinction and tries to set permissions for log directories named task-attempt-id.cleanup. This is a NO-OP. Typically the task cleanup runs on the same node that ran the original task attempt as well. So, the task log directories are already properly initialized. However, the task cleanup can run on a node that has not run the original task attempt. In that case, the initialization would not happen and this could result in the cleanup task failing.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.