You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/05/13 15:43:46 UTC

[GitHub] [apisix] yunwei37 commented on a diff in pull request #7035: docs: sync Chinese benchmark doc and add notes on running the benchmark

yunwei37 commented on code in PR #7035:
URL: https://github.com/apache/apisix/pull/7035#discussion_r872538637


##########
docs/zh/latest/benchmark.md:
##########
@@ -49,6 +49,29 @@ title: 压力测试
 
 ![flamegraph-1](../../assets/images/flamegraph-1.jpg)
 
+如果想在机器上运行基准测试，你应该同时运行另一个 NGINX 来监听 80 端口：

Review Comment:
   Changing this sentence may lead to some ambiguity: is one NGINX listening on port 80 or both? Also, one of the two NGINXs should be started by the APISIX command and does not require an additional manual start.
   
   修改这句话可能会带来一些歧义：到底是一个 NGINX 在监听 80 端口还是两个都在监听 80 端口呢？另外这两个 NGINX 其中一个 NGINX 应该是由 APISIX 命令启动的，并不需要额外手动启动一次。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org