You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dubbo.apache.org by GitBox <gi...@apache.org> on 2018/04/21 06:07:34 UTC
[GitHub] ralf0131 commented on a change in pull request #1612:
[Dubbo-Config] replace by Constants.
ralf0131 commented on a change in pull request #1612: [Dubbo-Config] replace by Constants.
URL: https://github.com/apache/incubator-dubbo/pull/1612#discussion_r182027672
##########
File path: dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/beans/factory/annotation/ServiceAnnotationBeanPostProcessor.java
##########
@@ -413,7 +413,7 @@ private AbstractBeanDefinition buildServiceBeanDefinition(Service service, Class
List<RuntimeBeanReference> protocolRuntimeBeanReferences = toRuntimeBeanReferences(protocolConfigBeanNames);
- if (!registryRuntimeBeanReferences.isEmpty()) {
+ if (!protocolRuntimeBeanReferences.isEmpty()) {
Review comment:
Why do we need this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services