You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Xiaodong DENG (JIRA)" <ji...@apache.org> on 2018/08/15 05:17:00 UTC

[jira] [Closed] (AIRFLOW-2872) Implement "Ad Hoc Query" in /www_rbac, and refine existing QueryView()

     [ https://issues.apache.org/jira/browse/AIRFLOW-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Xiaodong DENG closed AIRFLOW-2872.
----------------------------------
    Resolution: Won't Fix

> Implement "Ad Hoc Query" in /www_rbac, and refine existing QueryView()
> ----------------------------------------------------------------------
>
>                 Key: AIRFLOW-2872
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2872
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: ui
>            Reporter: Xiaodong DENG
>            Assignee: Xiaodong DENG
>            Priority: Critical
>
> To implement "Ad Hoc Query" in for RBAC in /www_rbac, based on the existing implementation in /www.
> In addition, refine the existing QueryView():
>  # The ".csv" button in *Ad Hoc Query* view is responding with a plain text file, rather than a CSV file (even though users can manually change the extension).
>  # Argument 'has_data' passed to the template is not used by the template 'airflow/query.html'.
>  # Sometimes get errors 'UnboundLocalError: local variable 'df' referenced before assignment'
>  # 'result = df.to_html()' should only be invoked when user doesn NOT choose '.csv'. Otherwise it's a waste of resource to invoke 'df.to_html()' since the result it returns will not be used if user askes for CSV downloading instead of a html page.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)