[jira] [Commented] (TAP5-2430) CompressionAnalyzer should provide a reasonable exception when the content type is null

["Howard M. Lewis Ship (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAP5-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252049#comment-14252049 ] 

Howard M. Lewis Ship commented on TAP5-2430:
--------------------------------------------

I think it should still throw an exception as every response must have some content type, just not a bare NPE.

> CompressionAnalyzer should provide a reasonable exception when the content type is null
> ---------------------------------------------------------------------------------------
>
>                 Key: TAP5-2430
>                 URL: https://issues.apache.org/jira/browse/TAP5-2430
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.4
>            Reporter: George Christman
>
> CompressionAnalyzer should probably return false on a null content type rather than throw an exception. 
> Caused by: java.lang.NullPointerException at org.apache.tapestry5.internal.
> services.assets.CompressionAnalyzerImpl.isCompressable(CompressionAnalyzerImpl.java:32)
> at $CompressionAnalyzer_10e85f85a5.isCompressable(Unknown Source) at
> org.apache.tapestry5.internal.gzip.BufferedGZipOutputStream.openResponseOutputStream(BufferedGZipOutputStream.java:77) 
> http://apache-tapestry-mailing-list-archives.1045711.n5.nabble.com/CompressionAnalyzerImpl-exception-td5729486.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)