You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/01/11 06:59:58 UTC

[GitHub] [pulsar] Renkai commented on a change in pull request #9096: PIP 76: Streaming Offload(Part I)

Renkai commented on a change in pull request #9096:
URL: https://github.com/apache/pulsar/pull/9096#discussion_r554813160



##########
File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedger.java
##########
@@ -594,4 +593,6 @@ void asyncSetProperties(Map<String, String> properties, final AsyncCallbacks.Upd
      * Get the ManagedLedgerInterceptor for ManagedLedger.
      * */
     ManagedLedgerInterceptor getManagedLedgerInterceptor();
+
+    CompletableFuture<LedgerMetadata> getRawLedgerMetadata(long ledgerId);

Review comment:
       We use `LedgerMetadata` because we need to use tiered storage to implement a `org.apache.bookkeeper.client.api.ReadHandle`, which is also a specific interface for bookkeeper, I think it's not avoidable.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org