You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/02/28 12:24:00 UTC

[jira] [Commented] (AIRFLOW-6944) Allow AWS DataSync to "catch up" when Task is already running

    [ https://issues.apache.org/jira/browse/AIRFLOW-6944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17047540#comment-17047540 ] 

ASF GitHub Bot commented on AIRFLOW-6944:
-----------------------------------------

baolsen commented on pull request #7585: [AIRFLOW-6944] Allow AWS DataSync to "catch up" when Task is already …
URL: https://github.com/apache/airflow/pull/7585
 
 
   …running
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Allow AWS DataSync to "catch up" when Task is already running
> -------------------------------------------------------------
>
>                 Key: AIRFLOW-6944
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6944
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: aws
>    Affects Versions: 1.10.9
>            Reporter: Bjorn Olsen
>            Assignee: Bjorn Olsen
>            Priority: Minor
>
> Current AWS DataSyncOperator attempts to start running a DataSync Task, with no regard / check for whether the task is already running or not. This attempt will fail (correctly).
> It is useful to have capability to optionally allow the operator to "catch up" instead of starting the Task - if the Task is of a particular status eg 'QUEUED' then we might want to wait for the currently Queued one to complete, instead of failing or instead of submitting another one (and snowballing). 
>  For example, this scenario can happen if the task was previously submitted but the Airflow Operator timed out waiting for it, when DataSync is busy.
> Or, maybe we want to wait for the Queued task to complete and then submit another Task anyway...
> Allowing the user some options for starting the Task depending on Status, allows for various use cases.
> However, the current functionality of "Fail if the Task can't be started" should remain default, to prevent unintentional problems which can arise if we instead decided to always wait if there is already a task queued. For example if the previous task has different Include filters than the new task, then logically they aren't the same.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)