You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/02/28 21:52:55 UTC
[GitHub] [couchdb-pkg] jjrodrig opened a new pull request #62: Do not
replace vm.args during update
jjrodrig opened a new pull request #62: Do not replace vm.args during update
URL: https://github.com/apache/couchdb-pkg/pull/62
<!-- Thank you for your contribution!
Please file this form by replacing the Markdown comments
with your text. If a section needs no action - remove it.
Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
of code collaboration. Positive feedback is represented +1 from committers
and negative is a -1. The -1 also means veto, and needs to be addressed
to proceed. Once there are no objections, the PR can be merged by a
CouchDB committer.
See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
## Overview
Do not replace vm.args config file when updating package.
## Testing recommendations
<!-- Describe how we can test your changes.
Does it provides any behaviour that the end users
could notice? -->
## GitHub issue number
<!-- If this is a significant change, please file a separate issue at:
https://github.com/apache/couchdb-pkg/issues
and include the number here and in commit message(s) using
syntax like "Fixes #472" or "Fixes apache/couchdb#472". -->
## Related Pull Requests
<!-- If your changes affects multiple components in different
repositories please put links to those pull requests here. -->
## Checklist
- [ ] Code is written and works correctly;
- [ ] Changes are covered by tests;
- [ ] Documentation reflects the changes;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-pkg] wohali commented on issue #62: Do not replace vm.args
during update
Posted by GitBox <gi...@apache.org>.
wohali commented on issue #62: Do not replace vm.args during update
URL: https://github.com/apache/couchdb-pkg/pull/62#issuecomment-593225848
@rnewson Same as local.ini now.
If it's not been changed by a user we'll overwrite it, if not we won't and put our file as `vm.args.rpmnew`
https://www.cl.cam.ac.uk/~jw35/docs/rpm_config.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-pkg] jjrodrig merged pull request #62: Do not replace
vm.args during update
Posted by GitBox <gi...@apache.org>.
jjrodrig merged pull request #62: Do not replace vm.args during update
URL: https://github.com/apache/couchdb-pkg/pull/62
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-pkg] wohali commented on issue #62: Do not replace vm.args
during update
Posted by GitBox <gi...@apache.org>.
wohali commented on issue #62: Do not replace vm.args during update
URL: https://github.com/apache/couchdb-pkg/pull/62#issuecomment-593485898
@rnewson No prompt, but a warning, which is OK I guess. Should look like:
```
warning: /opt/couchdb/etc/vm.args created as //opt/couchdb/etc/vm.args.rpmnew
```
Note: above is simulated, I haven't tried an upgrade from 2.3.1 to the new package yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-pkg] rnewson commented on issue #62: Do not replace
vm.args during update
Posted by GitBox <gi...@apache.org>.
rnewson commented on issue #62: Do not replace vm.args during update
URL: https://github.com/apache/couchdb-pkg/pull/62#issuecomment-593460257
ah super. in debian land there'd be a prompt to diff/merge, does that not happen in rpm land?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-pkg] rnewson commented on issue #62: Do not replace
vm.args during update
Posted by GitBox <gi...@apache.org>.
rnewson commented on issue #62: Do not replace vm.args during update
URL: https://github.com/apache/couchdb-pkg/pull/62#issuecomment-593166498
how will we deliver updated settings here in future upgrades?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-pkg] jjrodrig commented on issue #62: Do not replace
vm.args during update
Posted by GitBox <gi...@apache.org>.
jjrodrig commented on issue #62: Do not replace vm.args during update
URL: https://github.com/apache/couchdb-pkg/pull/62#issuecomment-593160212
Thanks @wohali
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-pkg] jjrodrig commented on issue #62: Do not replace
vm.args during update
Posted by GitBox <gi...@apache.org>.
jjrodrig commented on issue #62: Do not replace vm.args during update
URL: https://github.com/apache/couchdb-pkg/pull/62#issuecomment-593492916
I've tested the current 3.0.0 package update in my centos 7 environment. This is the output:
```
Updating : couchdb-3.0.0-1.el7.x86_64 1/2
waring:/opt/couchdb/etc/local.ini created as /opt/couchdb/etc/local.ini.rpmnew
```
We should have the same waring for vm.args
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services