[GitHub] [incubator-echarts] 100pah commented on issue #13678: realtimeSort log axis issue

[GitBox <gi...@apache.org>]

100pah commented on issue #13678:
URL: https://github.com/apache/incubator-echarts/issues/13678#issuecomment-757116526


   
   ![image](https://user-images.githubusercontent.com/1956569/104087075-17a30b80-5298-11eb-8654-1a7099814a90.png)
   
   
   To fix this issue, we might:
   
   + See `LogScale['unionExtentFromData']`: we might add param to the method `List['getApproximateExtent']` and `List['getDataExtent']` to union data without that `<= 0`. Otherwise the logScale extent will not be correct (e.g., [-Infinity, 10]).
   + Either 
       + In `BarView`, check wether the el has invalid layout (has NaN) and mark as `ignore`.
       + In `zrender`, if the Path has invalid shape params (NaN), do not render them.
   + Fix the animation that from a NaN prop.
   
   Test case:
   ```js
               require([
                   'echarts'
               ], function (echarts) {
                   var data = [0, 1, 10, 100, 1000];
                   var option = {
                       xAxis: {
                           type: 'log'
                       },
                       yAxis: {
                           type: 'category',
                           data: ['a', 'b', 'c', 'd', 'e']
                       },
                       series: [{
                           type: 'bar',
                           data: data,
                           label: { show: true, position: 'right' }
                       }]
                   };
   
                   var chart = testHelper.create(echarts, 'main1', {
                       title: [
                           'click "all +10"',
                           'check the x extent should be correct',
                           'the 0 bar should be displayed with animation'
                       ],
                       option: option,
                       buttons: [{
                           text: 'all +10',
                           onclick: function () {
                               for (var i = 0; i < data.length; i++) {
                                   data[i] += 10;
                               }
                               chart.setOption({
                                   series: {
                                       data: data
                                   }
                               });
                           }
                       }]
                   });
               });
   
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org