[GitHub] [airflow] lwyszomi commented on a change in pull request #18699: Dataflow Operators - use project and location from job in on_kill method.

[GitBox <gi...@apache.org>]

lwyszomi commented on a change in pull request #18699:
URL: https://github.com/apache/airflow/pull/18699#discussion_r721429685



##########
File path: airflow/providers/google/cloud/hooks/dataflow.py
##########
@@ -622,7 +622,7 @@ def start_template_dataflow(
         dataflow_template: str,
         project_id: str,
         append_job_name: bool = True,
-        on_new_job_id_callback: Optional[Callable[[str], None]] = None,
+        on_new_job_callback: Optional[Callable[[dict], None]] = None,

Review comment:
       @mik-laj A little, We need the information like 'project_id' and 'location' from Job not from the config. In the operator we have I think 3 or 4 possibilieties to define that properties, so If we want kill correct job in the correct location we should use properties from Job.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org