You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by "fgerlits (via GitHub)" <gi...@apache.org> on 2023/03/03 08:40:37 UTC

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1513: MINIFICPP-2053 Reduce CentOS image size in CI build

fgerlits commented on code in PR #1513:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1513#discussion_r1124162265


##########
docker/bionic/Dockerfile:
##########
@@ -21,6 +21,7 @@ FROM ubuntu:bionic AS build_deps
 LABEL maintainer="Apache NiFi <de...@nifi.apache.org>"
 
 ARG MINIFI_VERSION
+ARG DOCKER_MAKE_COMMAND=""

Review Comment:
   This should be `DOCKER_MAKE_TARGET`, instead of `DOCKER_MAKE_COMMAND`.
   
   Also, I would prefer to make the default make target `"all"`, instead of `""` implicitly defaulting to `"all"`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org