[GitHub] [iceberg] singhpk234 commented on pull request #6539: Core: Create commit groups in commit service offer in RewriteDataFilesCommitManager

[GitBox <gi...@apache.org>]

singhpk234 commented on PR #6539:
URL: https://github.com/apache/iceberg/pull/6539#issuecomment-1380903500

   Sure @jackye1995, presently I didn't add new ut's to this pr as the ut i was thinking of adding : 
   1. make sure a batch is not commited twice 
   2. if number of rewrites are not a multiple of batch size, making sure all the rewrites are already committed 
   were already present as part of existing UT's, Happy to add / think for more UT's if the above cases on top of my mind are not sufficient.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org