[GitHub] [incubator-celeborn] onebox-li commented on a diff in pull request #1557: [CELEBORN-642] Improve metrics and update grafana

["onebox-li (via GitHub)" <gi...@apache.org>]

onebox-li commented on code in PR #1557:
URL: https://github.com/apache/incubator-celeborn/pull/1557#discussion_r1221679508


##########
common/src/main/java/org/apache/celeborn/common/network/util/NettyUtils.java:
##########
@@ -139,22 +142,27 @@ public static PooledByteBufAllocator getPooledByteBufAllocator(
         String poolName = "default-netty-pool";
         String moduleName = conf.getModuleName();
         if (!moduleName.isEmpty()) {
-          poolName =
-              moduleName
-                  + "-"
-                  + allocatorsIndex.compute(
-                      moduleName,
-                      (k, v) -> {
-                        if (v == null) {
-                          v = 0;
-                        } else {
-                          v = v + 1;
-                        }
-                        return v;
-                      });
+          poolName = moduleName;
+          int index =
+              allocatorsIndex.compute(
+                  moduleName,
+                  (k, v) -> {
+                    if (v == null) {
+                      v = 0;
+                    } else {
+                      v = v + 1;
+                    }
+                    return v;
+                  });

Review Comment:
   thx, updated



##########
common/src/main/java/org/apache/celeborn/common/network/util/NettyUtils.java:
##########
@@ -122,14 +124,15 @@ private static PooledByteBufAllocator getSharedPooledByteBufAllocator(
         // each core should have one arena to allocate memory
         _allocator = createPooledByteBufAllocator(true, true, conf.networkAllocatorArenas());
         new NettyMemoryMetrics(
-            _allocator, "shared-pool", conf.networkAllocatorVerboseMetric(), source);
+            _allocator, "shared-pool", conf.networkAllocatorVerboseMetric(), source, null);
       }
       return _allocator;
     }
   }
 
   public static PooledByteBufAllocator getPooledByteBufAllocator(
       TransportConf conf, AbstractSource source, boolean allowCache) {
+    Map<String, String> labels = null;

Review Comment:
   thx, updated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org