You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by ul...@apache.org on 2022/06/27 03:59:21 UTC

[incubator-kyuubi] branch master updated: [KYUUBI #2943][Bug][K8S] Remove Start Local Kyuubi Server For Kyuubi On K8S Test

This is an automated email from the ASF dual-hosted git repository.

ulyssesyou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-kyuubi.git


The following commit(s) were added to refs/heads/master by this push:
     new caa3ed2aa [KYUUBI #2943][Bug][K8S] Remove Start Local Kyuubi Server For Kyuubi On K8S Test
caa3ed2aa is described below

commit caa3ed2aac2cfc5301146e78f685b9a864aa79e2
Author: zwangsheng <22...@qq.com>
AuthorDate: Mon Jun 27 11:59:09 2022 +0800

    [KYUUBI #2943][Bug][K8S] Remove Start Local Kyuubi Server For Kyuubi On K8S Test
    
    ### _Why are the changes needed?_
    
    With #2943
    close #2943
    
    ### _How was this patch tested?_
    - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
    
    - [ ] Add screenshots for manual tests if appropriate
    
    - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
    
    Closes #2944 from zwangsheng/fix/remove_useless_server.
    
    Closes #2943
    
    6656d0ca [zwangsheng] fix test
    faac8ff9 [zwangsheng] fix
    57677ea5 [zwangsheng] remove
    
    Authored-by: zwangsheng <22...@qq.com>
    Signed-off-by: ulysses-you <ul...@apache.org>
---
 .../kubernetes/test/WithKyuubiServerOnKubernetes.scala      | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)

diff --git a/integration-tests/kyuubi-kubernetes-it/src/test/scala/org/apache/kyuubi/kubernetes/test/WithKyuubiServerOnKubernetes.scala b/integration-tests/kyuubi-kubernetes-it/src/test/scala/org/apache/kyuubi/kubernetes/test/WithKyuubiServerOnKubernetes.scala
index c9d71c8a2..161011624 100644
--- a/integration-tests/kyuubi-kubernetes-it/src/test/scala/org/apache/kyuubi/kubernetes/test/WithKyuubiServerOnKubernetes.scala
+++ b/integration-tests/kyuubi-kubernetes-it/src/test/scala/org/apache/kyuubi/kubernetes/test/WithKyuubiServerOnKubernetes.scala
@@ -19,20 +19,13 @@ package org.apache.kyuubi.kubernetes.test
 
 import io.fabric8.kubernetes.client.DefaultKubernetesClient
 
-import org.apache.kyuubi.WithKyuubiServer
-import org.apache.kyuubi.config.KyuubiConf
+import org.apache.kyuubi.KyuubiFunSuite
 
-trait WithKyuubiServerOnKubernetes extends WithKyuubiServer {
-  protected val kyuubiServerConf: KyuubiConf = KyuubiConf()
+trait WithKyuubiServerOnKubernetes extends KyuubiFunSuite {
   protected def connectionConf: Map[String, String] = Map.empty
   private val miniKubernetesClient: DefaultKubernetesClient = MiniKube.getKubernetesClient
 
-  final override protected lazy val conf: KyuubiConf = {
-    connectionConf.foreach { case (k, v) => kyuubiServerConf.set(k, v) }
-    kyuubiServerConf
-  }
-
-  override protected def getJdbcUrl: String = {
+  protected def getJdbcUrl: String = {
     val kyuubiServers =
       miniKubernetesClient.pods().list().getItems
     assert(kyuubiServers.size() == 1)