[GitHub] [couchdb] nickva commented on a diff in pull request #4505: Treat javascript internal errors as fatal

["nickva (via GitHub)" <gi...@apache.org>]

nickva commented on code in PR #4505:
URL: https://github.com/apache/couchdb/pull/4505#discussion_r1152438504


##########
share/server/loop.js:
##########
@@ -133,6 +133,9 @@ var Loop = function() {
     } else if (e.error && e.reason) {
       // compatibility with old error format
       respond(["error", e.error, e.reason]);
+    } else if (e.name == "InternalError") {
+      respond(["error", e.name, e.message]);
+      quit(-1);

Review Comment:
   Good call on moving it up. It's belt and suspenders if we crash outside of the view function itself for instance when serializing the data to be returned back to the user.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org