You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/11/12 04:58:40 UTC

[GitHub] [shardingsphere-elasticjob] TeslaCN opened a new pull request #1713: Release HTTP request after handling

TeslaCN opened a new pull request #1713:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1713


   Fixes #1712 .
   
   Changes proposed in this pull request:
   - Release HTTP request after handling.
   - Simplify NettyRestfulService.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob] codecov-io edited a comment on pull request #1713: Release HTTP request after handling

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1713:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1713#issuecomment-725840321


   # [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713?src=pr&el=h1) Report
   > Merging [#1713](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713?src=pr&el=desc) (d918787) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/3b88d317f3fd52b0a68b1ebddbfe0b3ad1a45568?el=desc) (3b88d31) will **decrease** coverage by `0.00%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713/graphs/tree.svg?width=650&height=150&src=pr&token=8ZMVc4Yo4Z)](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1713      +/-   ##
   ============================================
   - Coverage     86.07%   86.07%   -0.01%     
   + Complexity      106      105       -1     
   ============================================
     Files           252      252              
     Lines          5682     5681       -1     
     Branches        878      878              
   ============================================
   - Hits           4891     4890       -1     
     Misses          477      477              
     Partials        314      314              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...sphere/elasticjob/restful/NettyRestfulService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlc3RmdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvcmVzdGZ1bC9OZXR0eVJlc3RmdWxTZXJ2aWNlLmphdmE=) | `82.60% <ø> (-2.01%)` | `0.00 <0.00> (-1.00)` | |
   | [...sticjob/restful/pipeline/HandleMethodExecutor.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlc3RmdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvcmVzdGZ1bC9waXBlbGluZS9IYW5kbGVNZXRob2RFeGVjdXRvci5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713?src=pr&el=footer). Last update [3b88d31...7b7badc](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob] Technoboy- merged pull request #1713: Release HTTP request after handling

Posted by GitBox <gi...@apache.org>.
Technoboy- merged pull request #1713:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1713


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob] codecov-io edited a comment on pull request #1713: Release HTTP request after handling

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1713:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1713#issuecomment-725840321


   # [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713?src=pr&el=h1) Report
   > Merging [#1713](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713?src=pr&el=desc) (7b7badc) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/3b88d317f3fd52b0a68b1ebddbfe0b3ad1a45568?el=desc) (3b88d31) will **decrease** coverage by `0.07%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713/graphs/tree.svg?width=650&height=150&src=pr&token=8ZMVc4Yo4Z)](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1713      +/-   ##
   ============================================
   - Coverage     86.07%   86.00%   -0.08%     
   + Complexity      106      105       -1     
   ============================================
     Files           252      252              
     Lines          5682     5682              
     Branches        878      878              
   ============================================
   - Hits           4891     4887       -4     
   - Misses          477      478       +1     
   - Partials        314      317       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...sphere/elasticjob/restful/NettyRestfulService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlc3RmdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvcmVzdGZ1bC9OZXR0eVJlc3RmdWxTZXJ2aWNlLmphdmE=) | `82.60% <ø> (-2.01%)` | `0.00 <0.00> (-1.00)` | |
   | [...sticjob/restful/pipeline/HandleMethodExecutor.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlc3RmdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvcmVzdGZ1bC9waXBlbGluZS9IYW5kbGVNZXRob2RFeGVjdXRvci5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
   | [...ticjob/restful/pipeline/HttpRequestDispatcher.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlc3RmdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvcmVzdGZ1bC9waXBlbGluZS9IdHRwUmVxdWVzdERpc3BhdGNoZXIuamF2YQ==) | `97.36% <100.00%> (+0.07%)` | `0.00 <0.00> (ø)` | |
   | [...e/shardingsphere/elasticjob/infra/env/IpUtils.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS9lbnYvSXBVdGlscy5qYXZh) | `60.00% <0.00%> (-4.62%)` | `0.00% <0.00%> (ø%)` | |
   | [...ticjob/lite/internal/snapshot/SnapshotService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc25hcHNob3QvU25hcHNob3RTZXJ2aWNlLmphdmE=) | `80.95% <0.00%> (-1.59%)` | `1.00% <0.00%> (ø%)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713?src=pr&el=footer). Last update [3b88d31...7b7badc](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob] codecov-io commented on pull request #1713: Release HTTP request after handling

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1713:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1713#issuecomment-725840321


   # [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713?src=pr&el=h1) Report
   > Merging [#1713](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713?src=pr&el=desc) (3a04837) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/3b88d317f3fd52b0a68b1ebddbfe0b3ad1a45568?el=desc) (3b88d31) will **decrease** coverage by `0.02%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713/graphs/tree.svg?width=650&height=150&src=pr&token=8ZMVc4Yo4Z)](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1713      +/-   ##
   ============================================
   - Coverage     86.07%   86.05%   -0.03%     
   + Complexity      106      105       -1     
   ============================================
     Files           252      252              
     Lines          5682     5680       -2     
     Branches        878      878              
   ============================================
   - Hits           4891     4888       -3     
     Misses          477      477              
   - Partials        314      315       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...sphere/elasticjob/restful/NettyRestfulService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlc3RmdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvcmVzdGZ1bC9OZXR0eVJlc3RmdWxTZXJ2aWNlLmphdmE=) | `82.60% <ø> (-2.01%)` | `0.00 <0.00> (-1.00)` | |
   | [...sticjob/restful/pipeline/HandleMethodExecutor.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlc3RmdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvcmVzdGZ1bC9waXBlbGluZS9IYW5kbGVNZXRob2RFeGVjdXRvci5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
   | [...ticjob/lite/internal/snapshot/SnapshotService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc25hcHNob3QvU25hcHNob3RTZXJ2aWNlLmphdmE=) | `80.95% <0.00%> (-1.59%)` | `1.00% <0.00%> (ø%)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713?src=pr&el=footer). Last update [3b88d31...3a04837](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob] codecov-io edited a comment on pull request #1713: Release HTTP request after handling

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1713:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1713#issuecomment-725840321


   # [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713?src=pr&el=h1) Report
   > Merging [#1713](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713?src=pr&el=desc) (7b7badc) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/3b88d317f3fd52b0a68b1ebddbfe0b3ad1a45568?el=desc) (3b88d31) will **decrease** coverage by `0.01%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713/graphs/tree.svg?width=650&height=150&src=pr&token=8ZMVc4Yo4Z)](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1713      +/-   ##
   ============================================
   - Coverage     86.07%   86.06%   -0.02%     
   + Complexity      106      105       -1     
   ============================================
     Files           252      252              
     Lines          5682     5682              
     Branches        878      878              
   ============================================
   - Hits           4891     4890       -1     
     Misses          477      477              
   - Partials        314      315       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...sphere/elasticjob/restful/NettyRestfulService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlc3RmdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvcmVzdGZ1bC9OZXR0eVJlc3RmdWxTZXJ2aWNlLmphdmE=) | `82.60% <ø> (-2.01%)` | `0.00 <0.00> (-1.00)` | |
   | [...sticjob/restful/pipeline/HandleMethodExecutor.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlc3RmdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvcmVzdGZ1bC9waXBlbGluZS9IYW5kbGVNZXRob2RFeGVjdXRvci5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
   | [...ticjob/restful/pipeline/HttpRequestDispatcher.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlc3RmdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvcmVzdGZ1bC9waXBlbGluZS9IdHRwUmVxdWVzdERpc3BhdGNoZXIuamF2YQ==) | `97.36% <100.00%> (+0.07%)` | `0.00 <0.00> (ø)` | |
   | [...ticjob/lite/internal/snapshot/SnapshotService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc25hcHNob3QvU25hcHNob3RTZXJ2aWNlLmphdmE=) | `80.95% <0.00%> (-1.59%)` | `1.00% <0.00%> (ø%)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713?src=pr&el=footer). Last update [3b88d31...7b7badc](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1713?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org