You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/25 10:31:06 UTC
[GitHub] [flink] MartijnVisser opened a new pull request #18502: [hotfix][docs][kafka] Add explanation how Kafka Source deals with idl…
MartijnVisser opened a new pull request #18502:
URL: https://github.com/apache/flink/pull/18502
…eness when parallelism is higher then the number of partitions
## What is the purpose of the change
* Clarifying idleness in Kafka Source
## Brief change log
* This PR adds a section to the Kafka Source documentation to explain what happens with the Kafka Source with regards to idleness when parallelism is higher then the number of partitions
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18502: [hotfix][docs][kafka] Add explanation how Kafka Source deals with idl…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18502:
URL: https://github.com/apache/flink/pull/18502#issuecomment-1021048562
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1f83802ae2f9a2dfd9700dfb20e39a7756ee0ff2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1f83802ae2f9a2dfd9700dfb20e39a7756ee0ff2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1f83802ae2f9a2dfd9700dfb20e39a7756ee0ff2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18502: [hotfix][docs][kafka] Add explanation how Kafka Source deals with idl…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18502:
URL: https://github.com/apache/flink/pull/18502#issuecomment-1021048562
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1f83802ae2f9a2dfd9700dfb20e39a7756ee0ff2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30141",
"triggerID" : "1f83802ae2f9a2dfd9700dfb20e39a7756ee0ff2",
"triggerType" : "PUSH"
}, {
"hash" : "d446d2d97b5b87ed87a923b1122c32602dc526b3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d446d2d97b5b87ed87a923b1122c32602dc526b3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1f83802ae2f9a2dfd9700dfb20e39a7756ee0ff2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30141)
* d446d2d97b5b87ed87a923b1122c32602dc526b3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18502: [hotfix][docs][kafka] Add explanation how Kafka Source deals with idl…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18502:
URL: https://github.com/apache/flink/pull/18502#issuecomment-1021044442
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 1f83802ae2f9a2dfd9700dfb20e39a7756ee0ff2 (Tue Jan 25 10:36:41 UTC 2022)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on a change in pull request #18502: [hotfix][docs][kafka] Add explanation how Kafka Source deals with idl…
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #18502:
URL: https://github.com/apache/flink/pull/18502#discussion_r791593327
##########
File path: docs/content.zh/docs/connectors/datastream/kafka.md
##########
@@ -176,6 +176,15 @@ env.fromSource(kafkaSource, new CustomWatermarkStrategy(), "Kafka Source With Cu
```
[这篇文档]({{< ref "docs/dev/datastream/event-time/generating_watermarks.md" >}})描述了如何自定义水印策略（```WatermarkStrategy```）。
+### Idleness
Review comment:
```suggestion
### 空闲
如果并行度高于分区数，Kafka Source 不会自动进入空闲状态。您将需要降低并行度或向水印策略添加空闲超时。如果在这段时间内没有记录在流的分区中流动，则该分区被视为“空闲”并且不会阻止下游操作符中水印的进度。
```
##########
File path: docs/content.zh/docs/connectors/datastream/kafka.md
##########
@@ -176,6 +176,15 @@ env.fromSource(kafkaSource, new CustomWatermarkStrategy(), "Kafka Source With Cu
```
[这篇文档]({{< ref "docs/dev/datastream/event-time/generating_watermarks.md" >}})描述了如何自定义水印策略（```WatermarkStrategy```）。
+### Idleness
Review comment:
```suggestion
### 空闲
如果并行度高于分区数，Kafka Source 不会自动进入空闲状态。您将需要降低并行度或向水印策略添加空闲超时。如果在这段时间内没有记录在流的分区中流动，则该分区被视为“空闲”并且不会阻止下游操作符中水印的进度。
[这篇文档]({{< ref "docs/dev/datastream/event-time/generating_watermarks.md" >}}#dealing-with-idle-sources) 描述了有关如何定义 ```WatermarkStrategy#withIdleness``` 的详细信息.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on a change in pull request #18502: [hotfix][docs][kafka] Add explanation how Kafka Source deals with idl…
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #18502:
URL: https://github.com/apache/flink/pull/18502#discussion_r791593327
##########
File path: docs/content.zh/docs/connectors/datastream/kafka.md
##########
@@ -176,6 +176,15 @@ env.fromSource(kafkaSource, new CustomWatermarkStrategy(), "Kafka Source With Cu
```
[这篇文档]({{< ref "docs/dev/datastream/event-time/generating_watermarks.md" >}})描述了如何自定义水印策略（```WatermarkStrategy```）。
+### Idleness
Review comment:
```suggestion
### 空闲
如果并行度高于分区数，Kafka Source 不会自动进入空闲状态。您将需要降低并行度或向水印策略添加空闲超时。如果在这段时间内没有记录在流的分区中流动，则该分区被视为“空闲”并且不会阻止下游操作符中水印的进度。
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #18502: [hotfix][docs][kafka] Add explanation how Kafka Source deals with idl…
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on pull request #18502:
URL: https://github.com/apache/flink/pull/18502#issuecomment-1021173347
> LGTM 👍 @MartijnVisser do you also want to update the Chinese translation or do it separately?
I've updated the PR with the provided Chinese translation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18502: [FLINK-25818][Docs][Kafka] Add explanation how Kafka Source deals with idl…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18502:
URL: https://github.com/apache/flink/pull/18502#issuecomment-1021048562
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1f83802ae2f9a2dfd9700dfb20e39a7756ee0ff2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30141",
"triggerID" : "1f83802ae2f9a2dfd9700dfb20e39a7756ee0ff2",
"triggerType" : "PUSH"
}, {
"hash" : "d446d2d97b5b87ed87a923b1122c32602dc526b3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30151",
"triggerID" : "d446d2d97b5b87ed87a923b1122c32602dc526b3",
"triggerType" : "PUSH"
}, {
"hash" : "1bb532a98042963c9aeeac75303c63a6ba3b8de5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30217",
"triggerID" : "1bb532a98042963c9aeeac75303c63a6ba3b8de5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d446d2d97b5b87ed87a923b1122c32602dc526b3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30151)
* 1bb532a98042963c9aeeac75303c63a6ba3b8de5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30217)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul merged pull request #18502: [FLINK-25818][Docs][Kafka] Add explanation how Kafka Source deals with idl…
Posted by GitBox <gi...@apache.org>.
fapaul merged pull request #18502:
URL: https://github.com/apache/flink/pull/18502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18502: [hotfix][docs][kafka] Add explanation how Kafka Source deals with idl…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18502:
URL: https://github.com/apache/flink/pull/18502#issuecomment-1021048562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18502: [FLINK-25818][Docs][Kafka] Add explanation how Kafka Source deals with idl…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18502:
URL: https://github.com/apache/flink/pull/18502#issuecomment-1021048562
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1f83802ae2f9a2dfd9700dfb20e39a7756ee0ff2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30141",
"triggerID" : "1f83802ae2f9a2dfd9700dfb20e39a7756ee0ff2",
"triggerType" : "PUSH"
}, {
"hash" : "d446d2d97b5b87ed87a923b1122c32602dc526b3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30151",
"triggerID" : "d446d2d97b5b87ed87a923b1122c32602dc526b3",
"triggerType" : "PUSH"
}, {
"hash" : "1bb532a98042963c9aeeac75303c63a6ba3b8de5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1bb532a98042963c9aeeac75303c63a6ba3b8de5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d446d2d97b5b87ed87a923b1122c32602dc526b3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30151)
* 1bb532a98042963c9aeeac75303c63a6ba3b8de5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18502: [hotfix][docs][kafka] Add explanation how Kafka Source deals with idl…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18502:
URL: https://github.com/apache/flink/pull/18502#issuecomment-1021044442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18502: [hotfix][docs][kafka] Add explanation how Kafka Source deals with idl…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18502:
URL: https://github.com/apache/flink/pull/18502#issuecomment-1021048562
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1f83802ae2f9a2dfd9700dfb20e39a7756ee0ff2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30141",
"triggerID" : "1f83802ae2f9a2dfd9700dfb20e39a7756ee0ff2",
"triggerType" : "PUSH"
}, {
"hash" : "d446d2d97b5b87ed87a923b1122c32602dc526b3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30151",
"triggerID" : "d446d2d97b5b87ed87a923b1122c32602dc526b3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1f83802ae2f9a2dfd9700dfb20e39a7756ee0ff2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30141)
* d446d2d97b5b87ed87a923b1122c32602dc526b3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30151)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #18502: [hotfix][docs][kafka] Add explanation how Kafka Source deals with idl…
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on pull request #18502:
URL: https://github.com/apache/flink/pull/18502#issuecomment-1021173347
> LGTM 👍 @MartijnVisser do you also want to update the Chinese translation or do it separately?
I've updated the PR with the provided Chinese translation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18502: [hotfix][docs][kafka] Add explanation how Kafka Source deals with idl…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18502:
URL: https://github.com/apache/flink/pull/18502#issuecomment-1021048562
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1f83802ae2f9a2dfd9700dfb20e39a7756ee0ff2",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30141",
"triggerID" : "1f83802ae2f9a2dfd9700dfb20e39a7756ee0ff2",
"triggerType" : "PUSH"
}, {
"hash" : "d446d2d97b5b87ed87a923b1122c32602dc526b3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30151",
"triggerID" : "d446d2d97b5b87ed87a923b1122c32602dc526b3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1f83802ae2f9a2dfd9700dfb20e39a7756ee0ff2 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30141)
* d446d2d97b5b87ed87a923b1122c32602dc526b3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30151)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18502: [hotfix][docs][kafka] Add explanation how Kafka Source deals with idl…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18502:
URL: https://github.com/apache/flink/pull/18502#issuecomment-1021048562
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1f83802ae2f9a2dfd9700dfb20e39a7756ee0ff2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30141",
"triggerID" : "1f83802ae2f9a2dfd9700dfb20e39a7756ee0ff2",
"triggerType" : "PUSH"
}, {
"hash" : "d446d2d97b5b87ed87a923b1122c32602dc526b3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30151",
"triggerID" : "d446d2d97b5b87ed87a923b1122c32602dc526b3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d446d2d97b5b87ed87a923b1122c32602dc526b3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30151)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on a change in pull request #18502: [hotfix][docs][kafka] Add explanation how Kafka Source deals with idl…
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on a change in pull request #18502:
URL: https://github.com/apache/flink/pull/18502#discussion_r791699368
##########
File path: docs/content.zh/docs/connectors/datastream/kafka.md
##########
@@ -176,6 +176,15 @@ env.fromSource(kafkaSource, new CustomWatermarkStrategy(), "Kafka Source With Cu
```
[这篇文档]({{< ref "docs/dev/datastream/event-time/generating_watermarks.md" >}})描述了如何自定义水印策略（```WatermarkStrategy```）。
+### Idleness
Review comment:
Thank you so much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on a change in pull request #18502: [hotfix][docs][kafka] Add explanation how Kafka Source deals with idl…
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on a change in pull request #18502:
URL: https://github.com/apache/flink/pull/18502#discussion_r791699368
##########
File path: docs/content.zh/docs/connectors/datastream/kafka.md
##########
@@ -176,6 +176,15 @@ env.fromSource(kafkaSource, new CustomWatermarkStrategy(), "Kafka Source With Cu
```
[这篇文档]({{< ref "docs/dev/datastream/event-time/generating_watermarks.md" >}})描述了如何自定义水印策略（```WatermarkStrategy```）。
+### Idleness
Review comment:
Thank you so much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on a change in pull request #18502: [hotfix][docs][kafka] Add explanation how Kafka Source deals with idl…
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #18502:
URL: https://github.com/apache/flink/pull/18502#discussion_r791593327
##########
File path: docs/content.zh/docs/connectors/datastream/kafka.md
##########
@@ -176,6 +176,15 @@ env.fromSource(kafkaSource, new CustomWatermarkStrategy(), "Kafka Source With Cu
```
[这篇文档]({{< ref "docs/dev/datastream/event-time/generating_watermarks.md" >}})描述了如何自定义水印策略（```WatermarkStrategy```）。
+### Idleness
Review comment:
```suggestion
### 空闲
如果并行度高于分区数，Kafka Source 不会自动进入空闲状态。您将需要降低并行度或向水印策略添加空闲超时。如果在这段时间内没有记录在流的分区中流动，则该分区被视为“空闲”并且不会阻止下游操作符中水印的进度。
[这篇文档]({{< ref "docs/dev/datastream/event-time/generating_watermarks.md" >}}#dealing-with-idle-sources) 描述了有关如何定义 ```WatermarkStrategy#withIdleness``` 的详细信息.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18502: [hotfix][docs][kafka] Add explanation how Kafka Source deals with idl…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18502:
URL: https://github.com/apache/flink/pull/18502#issuecomment-1021048562
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1f83802ae2f9a2dfd9700dfb20e39a7756ee0ff2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30141",
"triggerID" : "1f83802ae2f9a2dfd9700dfb20e39a7756ee0ff2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1f83802ae2f9a2dfd9700dfb20e39a7756ee0ff2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30141)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #18502: [hotfix][docs][kafka] Add explanation how Kafka Source deals with idl…
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #18502:
URL: https://github.com/apache/flink/pull/18502#issuecomment-1022031621
@fapaul , help to merge this pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org