You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by superbobry <gi...@git.apache.org> on 2017/04/10 19:55:08 UTC
[GitHub] spark pull request #17598: [SPARK-20284][CORE] Make {Des,S}erializationStrea...
GitHub user superbobry opened a pull request:
https://github.com/apache/spark/pull/17598
[SPARK-20284][CORE] Make {Des,S}erializationStream extend Closeable
## What changes were proposed in this pull request?
This PR allows to use `SerializationStream` and `DeserializationStream` in try-with-resources.
## How was this patch tested?
`core` unit tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/criteo-forks/spark compression-stream-closeable
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17598.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17598
----
commit 75ba026db26171e0ed59d48d0ab2855f2a2af757
Author: Sergei Lebedev <s....@criteo.com>
Date: 2017-04-10T19:32:12Z
[SPARK-20284][CORE] Make {Des,S}erializationStream extend Closeable
This change allows to use these streams in try-with-resources.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17598: [SPARK-20284][CORE] Make {Des,S}erializationStream exten...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17598
**[Test build #3659 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3659/testReport)** for PR 17598 at commit [`75ba026`](https://github.com/apache/spark/commit/75ba026db26171e0ed59d48d0ab2855f2a2af757).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `abstract class SerializationStream extends Closeable `
* `abstract class DeserializationStream extends Closeable `
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17598: [SPARK-20284][CORE] Make {Des,S}erializationStream exten...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17598
Merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17598: [SPARK-20284][CORE] Make {Des,S}erializationStrea...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17598
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17598: [SPARK-20284][CORE] Make {Des,S}erializationStrea...
Posted by superbobry <gi...@git.apache.org>.
Github user superbobry commented on a diff in the pull request:
https://github.com/apache/spark/pull/17598#discussion_r110950456
--- Diff: core/src/main/scala/org/apache/spark/serializer/Serializer.scala ---
@@ -125,7 +125,7 @@ abstract class SerializerInstance {
* A stream for writing serialized objects.
*/
@DeveloperApi
-abstract class SerializationStream {
+abstract class SerializationStream extends Closeable {
--- End diff --
Sure, added that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17598: [SPARK-20284][CORE] Make {Des,S}erializationStream exten...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17598
**[Test build #3659 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3659/testReport)** for PR 17598 at commit [`75ba026`](https://github.com/apache/spark/commit/75ba026db26171e0ed59d48d0ab2855f2a2af757).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17598: [SPARK-20284][CORE] Make {Des,S}erializationStrea...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17598#discussion_r110777583
--- Diff: core/src/main/scala/org/apache/spark/serializer/Serializer.scala ---
@@ -125,7 +125,7 @@ abstract class SerializerInstance {
* A stream for writing serialized objects.
*/
@DeveloperApi
-abstract class SerializationStream {
+abstract class SerializationStream extends Closeable {
--- End diff --
Does the close() method need 'override' then?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17598: [SPARK-20284][CORE] Make {Des,S}erializationStream exten...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17598
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org