You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@edgent.apache.org by Cazen <gi...@git.apache.org> on 2016/06/14 02:13:22 UTC
[GitHub] incubator-quarks pull request #138: [QUARKS-204][WIP] Release target, creati...
GitHub user Cazen opened a pull request:
https://github.com/apache/incubator-quarks/pull/138
[QUARKS-204][WIP] Release target, creating the target/\u2026 structure
I compared the Ant build ```./ant -> target/java8``` and Gradle build ```./gradlew build -x test -> build/distributions/java8/``` using the ```find . | grep -v ext | sort``` script.
Although some differences are found, it has a substantially similar structure
1. Some javax related file name has been changed
- [ ] javax.websocket-client.jar(ant) -> quarks.connectors.javax.websocket-client.jar(gradle)
- [ ] javax.websocket-server.jar(ant) -> quarks.connectors.javax.websocket-server.jar(gradle)
- [ ] quarks.javax.websocket.jar(ant) -> ./connectors/quarks.javax.websocket/lib/(gradle)
2. There are no svt jar(quarks.test.svt.jar) exist in ant build(I think it's ant build script problem)
- [ ] ./test/svt/lib/quarks.test.svt.jar
Because I already started this PR for compare directories&files schema with ant build, it has not been reflected yet about gathered all the jar files in one place with @bjhargrave advise.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Cazen/incubator-quarks QUARKS-204
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quarks/pull/138.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #138
----
commit 9d50689985c0dce03fbe6117c284a55c385473f6
Author: cazen.lee <ca...@samsung.com>
Date: 2016-06-13T06:32:45Z
add copyJar function to root gradle script
commit 2a2f323e93a91768f159e9f37d40aad32975a82a
Author: cazen <ca...@apache.org>
Date: 2016-06-14T01:46:42Z
Chz target dir to using distsDir
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks pull request #138: [QUARKS-204][WIP] Release target, creati...
Posted by Cazen <gi...@git.apache.org>.
GitHub user Cazen reopened a pull request:
https://github.com/apache/incubator-quarks/pull/138
[QUARKS-204][WIP] Release target, creating the target/\u2026 structure
I compared the Ant build ```./ant -> target/java8``` and Gradle build ```./gradlew build -x test -> build/distributions/java8/``` using the ```find . | grep -v ext | sort``` script.
Although some differences are found, it has a substantially similar structure
1. Some javax related file name has been changed
- [ ] javax.websocket-client.jar(ant) -> quarks.connectors.javax.websocket-client.jar(gradle)
- [ ] javax.websocket-server.jar(ant) -> quarks.connectors.javax.websocket-server.jar(gradle)
- [ ] quarks.javax.websocket.jar(ant) -> ./connectors/quarks.javax.websocket/lib/(gradle)
2. There are no svt jar(quarks.test.svt.jar) exist in ant build(I think it's ant build script problem)
- [ ] ./test/svt/lib/quarks.test.svt.jar
Because I already started this PR for compare directories&files schema with ant build, it has not been reflected yet about gathered all the jar files in one place with @bjhargrave advise.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Cazen/incubator-quarks QUARKS-204
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quarks/pull/138.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #138
----
commit 9d50689985c0dce03fbe6117c284a55c385473f6
Author: cazen.lee <ca...@samsung.com>
Date: 2016-06-13T06:32:45Z
add copyJar function to root gradle script
commit 2a2f323e93a91768f159e9f37d40aad32975a82a
Author: cazen <ca...@apache.org>
Date: 2016-06-14T01:46:42Z
Chz target dir to using distsDir
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks pull request #138: [QUARKS-204] Release target, creating th...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quarks/pull/138
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks pull request #138: [QUARKS-204][WIP] Release target, creati...
Posted by Cazen <gi...@git.apache.org>.
Github user Cazen commented on a diff in the pull request:
https://github.com/apache/incubator-quarks/pull/138#discussion_r66899926
--- Diff: connectors/javax.websocket-client/build.gradle ---
@@ -11,8 +11,6 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-archivesBaseName = project.name
--- End diff --
Good day! @bjhargrave
Could I kindly ask this property(archivesBaseName) is used?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks pull request #138: [QUARKS-204][WIP] Release target, creati...
Posted by Cazen <gi...@git.apache.org>.
Github user Cazen closed the pull request at:
https://github.com/apache/incubator-quarks/pull/138
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---