You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "seawinde (via GitHub)" <gi...@apache.org> on 2024/03/14 12:11:51 UTC

[PR] [doc](nereids)Optimize doc and code usage [doris]

seawinde opened a new pull request, #32263:
URL: https://github.com/apache/doris/pull/32263

   ## Proposed changes
   
   Improve and optimize the documentation for transparent rewriting of materialized views.
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [doc](nereids)Optimize doc and code usage [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32263:
URL: https://github.com/apache/doris/pull/32263#issuecomment-1997303903

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [doc](nereids)Optimize doc and code usage [doris]

Posted by "seawinde (via GitHub)" <gi...@apache.org>.
seawinde commented on PR #32263:
URL: https://github.com/apache/doris/pull/32263#issuecomment-2008724187

   this is replaced by anohter pr https://github.com/apache/doris-website/pull/438, so this is closed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [doc](nereids)Optimize doc and code usage [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32263:
URL: https://github.com/apache/doris/pull/32263#issuecomment-2002892065

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [doc](nereids)Optimize doc and code usage [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32263:
URL: https://github.com/apache/doris/pull/32263#issuecomment-1997347372

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 38519 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 6e700e2cc738211c980b493a611b5ec82496a53e, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17672	4908	4105	4105
   q2	2020	157	150	150
   q3	10656	1138	927	927
   q4	7789	778	734	734
   q5	7463	2782	2763	2763
   q6	187	129	122	122
   q7	1178	837	839	837
   q8	9346	2038	1993	1993
   q9	7053	6524	6409	6409
   q10	8472	3499	3599	3499
   q11	427	230	211	211
   q12	613	296	303	296
   q13	17817	2855	2874	2855
   q14	275	252	246	246
   q15	496	456	444	444
   q16	483	396	393	393
   q17	959	561	645	561
   q18	7320	6482	6498	6482
   q19	1912	1465	1411	1411
   q20	560	298	284	284
   q21	6329	3503	3585	3503
   q22	375	303	294	294
   Total cold run time: 109402 ms
   Total hot run time: 38519 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4094	4089	4075	4075
   q2	322	224	227	224
   q3	2960	2786	2786	2786
   q4	1910	1587	1570	1570
   q5	5231	5258	5253	5253
   q6	190	119	118	118
   q7	2224	1846	1839	1839
   q8	3159	3319	3314	3314
   q9	8640	8578	8562	8562
   q10	3723	3732	3688	3688
   q11	547	450	431	431
   q12	743	553	553	553
   q13	16855	2864	2878	2864
   q14	281	250	247	247
   q15	484	449	441	441
   q16	470	427	415	415
   q17	1725	1468	1449	1449
   q18	7566	7183	7151	7151
   q19	1612	1564	1453	1453
   q20	1899	1712	1701	1701
   q21	4869	4643	4807	4643
   q22	523	469	457	457
   Total cold run time: 70027 ms
   Total hot run time: 53234 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [doc](nereids)Optimize doc and code usage [doris]

Posted by "seawinde (via GitHub)" <gi...@apache.org>.
seawinde commented on code in PR #32263:
URL: https://github.com/apache/doris/pull/32263#discussion_r1527411199


##########
fe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVCache.java:
##########
@@ -64,11 +64,8 @@ public static MTMVCache from(MTMV mtmv, ConnectContext connectContext) {
         Plan originPlan = planner.plan(unboundMvPlan, PhysicalProperties.ANY, ExplainLevel.REWRITTEN_PLAN);
         Plan mvPlan = originPlan.accept(new DefaultPlanRewriter<Object>() {
             @Override
-            public Plan visit(Plan plan, Object context) {
-                if (plan instanceof LogicalResultSink) {
-                    return ((LogicalResultSink<Plan>) plan).child();
-                }
-                return super.visit(plan, context);
+            public Plan visitLogicalResultSink(LogicalResultSink<? extends Plan> logicalResultSink, Object context) {
+                return logicalResultSink.child().accept(this, context);

Review Comment:
   this code is aim to remove the resultSink for query rewrite by materilized view later. Remove sort under result sink is  in another pr



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [doc](nereids)Optimize doc and code usage [doris]

Posted by "seawinde (via GitHub)" <gi...@apache.org>.
seawinde closed pull request #32263: [doc](nereids)Optimize doc and code usage
URL: https://github.com/apache/doris/pull/32263


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [doc](nereids)Optimize doc and code usage [doris]

Posted by "seawinde (via GitHub)" <gi...@apache.org>.
seawinde commented on PR #32263:
URL: https://github.com/apache/doris/pull/32263#issuecomment-1997305395

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [doc](nereids)Optimize doc and code usage [doris]

Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #32263:
URL: https://github.com/apache/doris/pull/32263#discussion_r1525732858


##########
fe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVCache.java:
##########
@@ -64,11 +64,8 @@ public static MTMVCache from(MTMV mtmv, ConnectContext connectContext) {
         Plan originPlan = planner.plan(unboundMvPlan, PhysicalProperties.ANY, ExplainLevel.REWRITTEN_PLAN);
         Plan mvPlan = originPlan.accept(new DefaultPlanRewriter<Object>() {
             @Override
-            public Plan visit(Plan plan, Object context) {
-                if (plan instanceof LogicalResultSink) {
-                    return ((LogicalResultSink<Plan>) plan).child();
-                }
-                return super.visit(plan, context);
+            public Plan visitLogicalResultSink(LogicalResultSink<? extends Plan> logicalResultSink, Object context) {
+                return logicalResultSink.child().accept(this, context);

Review Comment:
   file sink need keep order too. so u need override visitLogicalFileSink



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [doc](nereids)Optimize doc and code usage [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32263:
URL: https://github.com/apache/doris/pull/32263#issuecomment-2002892096

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org