You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/11 20:52:02 UTC
[GitHub] [spark] sarutak opened a new pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
sarutak opened a new pull request #28803:
URL: https://github.com/apache/spark/pull/28803
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR proposes to add pagination support for all-jobs timeline.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
If there are lots of jobs, rendering performance of all jobs timeline can significantly goes down. This issue is reported in SPARK-31967.
For example, the following operation can take >40 sec.
```
(1 to 1000).foreach(_ => sc.parallelize(1 to 10).collect)
```
Although it's not the fundamental solution, pagination can mitigate the issue.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes.
Before this change, all possible jobs are displayed in one page.
<img width="1437" alt="all-jobs-shown" src="https://user-images.githubusercontent.com/4736016/84437843-9dae9380-ac70-11ea-80db-deb847022ad3.png">
After this change, 2 text boxes are added.
One is to set the maximum number of jobs to be displayed in a page and the other is to set the page number.
`Go` button is also added and if it's pushed, jobs are re-rendered based on the page size and page number.
<img width="1437" alt="all-jobs-pagination" src="https://user-images.githubusercontent.com/4736016/84437254-a6529a00-ac6f-11ea-8694-e8b1cb1ff30a.png">
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
New testcase is added.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-655279892
**[Test build #125295 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125295/testReport)** for PR 28803 at commit [`0270bb9`](https://github.com/apache/spark/commit/0270bb9904b881be981f274db17736feda506728).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643576740
**[Test build #123965 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123965/testReport)** for PR 28803 at commit [`0270bb9`](https://github.com/apache/spark/commit/0270bb9904b881be981f274db17736feda506728).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643583191
**[Test build #123969 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123969/testReport)** for PR 28803 at commit [`0270bb9`](https://github.com/apache/spark/commit/0270bb9904b881be981f274db17736feda506728).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643582013
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #28803:
URL: https://github.com/apache/spark/pull/28803#discussion_r451282622
##########
File path: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala
##########
@@ -184,20 +188,52 @@ private[ui] class AllJobsPage(parent: JobsTab, store: AppStatusStore) extends We
val eventArrayAsStr =
(jobEventJsonAsStrSeq ++ executorEventJsonAsStrSeq).mkString("[", ",", "]")
- <span class="expand-application-timeline">
- <span class="expand-application-timeline-arrow arrow-closed"></span>
- <a data-toggle="tooltip" title={ToolTips.JOB_TIMELINE} data-placement="top">
- Event Timeline
- </a>
- </span> ++
- <div id="application-timeline" class="collapsed">
- <div class="control-panel">
- <div id="application-timeline-zoom-lock">
- <input type="checkbox"></input>
- <span>Enable zooming</span>
+ if (totalPages > 0) {
+ <span class="expand-application-timeline">
+ <span class="expand-application-timeline-arrow arrow-closed"></span>
+ <a data-toggle="tooltip" title={ToolTips.JOB_TIMELINE} data-placement="top">
+ Event Timeline
+ </a>
+ </span> ++
+ <div id="application-timeline" class="collapsed">
+ <div class="control-panel">
+ <div id="application-timeline-zoom-lock">
+ <input type="checkbox"></input>
+ <span>Enable zooming</span>
+ </div>
+ <div>
+ <form id={s"form-event-timeline-page"}
+ method="get"
+ action=""
+ class="form-inline justify-content-end"
+ style="width: 50%; margin-left: auto; margin-bottom: 0px;">
+ <label>Jobs:
+ {totalJobs}
+ .
+ {totalPages}
+ Pages. Jump to</label>
+ <input type="text"
+ name="jobs.eventTimelinePageNumber"
+ id={s"form-event-timeline-page-no"}
Review comment:
Exactly. I'll remove `s` prefix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-655283658
@sarutak I am really sorry I missed your ping last week.
The perf problem is resolved in https://github.com/apache/spark/pull/28806. If we want to avoid perf issue in the long term, I think we can avoid rendering the timeline by default.
I am +0 with the proposal. The pagination makes the visualization simpler, but also makes the UI usage more complex. If you insist, let's merge this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-652154162
Hi @gengliangwang, could you restart discussion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643599487
**[Test build #123969 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123969/testReport)** for PR 28803 at commit [`0270bb9`](https://github.com/apache/spark/commit/0270bb9904b881be981f274db17736feda506728).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-655280269
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-642979895
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123864/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643067149
@sarutak I just created https://github.com/apache/spark/pull/28806.
I believe downgrading the vis version is a safer solution. We need to hotfix this to Spark 3.0 ASAP
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643576860
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643581962
**[Test build #123965 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123965/testReport)** for PR 28803 at commit [`0270bb9`](https://github.com/apache/spark/commit/0270bb9904b881be981f274db17736feda506728).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-642979528
**[Test build #123864 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123864/testReport)** for PR 28803 at commit [`90b132b`](https://github.com/apache/spark/commit/90b132b23c98437b277ef4752612ad2661c5ae84).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-657763975
> I am +0 with the proposal. The pagination makes the visualization simpler, but also makes the UI usage more complex. If you insist, let's merge this one.
I wondered the pagination feature for task timeline is one compromise so I came up with bringing the idea into jobs timeline but this solution has both upside and downside as you suggested.
So, do you have any better idea to avoid being the timeline noisy?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-652154162
Hi @gengliangwang, shall we restart discussion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643576377
> I think we should make the two pagination sections consistent
The upper text fields are for timeline, while the lower ones are for the table so I think they should be independent each other.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-655333656
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643063667
> 1. if there are many stages in one job, the perf issue still exists
> 2. the two paginations in one page seem weird.
For 1), AllJobsPage is not affected even if a job has many stages isn't it? JobPage can be affect but we can apply the same solution. For 2), Yes, it's a little bit weird but the similar solution already exists in StagePage.
Even if no performance issue exists, lots of items rendered in one page can be too noisy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643042963
@sarutak I just confirmed that the issue is caused by #28192 . The issus can't be reproduced before the change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-642941333
I think we should make the two pagination sections consistent
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-642922984
cc: @gengliangwang
This improvement is not the fundamental solution for SPARK-31967 but mitigate it so I've filed as an independent issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-642923349
**[Test build #123864 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123864/testReport)** for PR 28803 at commit [`90b132b`](https://github.com/apache/spark/commit/90b132b23c98437b277ef4752612ad2661c5ae84).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643582014
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123965/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-655333656
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643583191
**[Test build #123969 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123969/testReport)** for PR 28803 at commit [`0270bb9`](https://github.com/apache/spark/commit/0270bb9904b881be981f274db17736feda506728).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-655280269
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643583329
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643582013
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-655330652
**[Test build #125295 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125295/testReport)** for PR 28803 at commit [`0270bb9`](https://github.com/apache/spark/commit/0270bb9904b881be981f274db17736feda506728).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-655278687
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-655333663
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125295/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #28803:
URL: https://github.com/apache/spark/pull/28803#discussion_r451282321
##########
File path: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala
##########
@@ -184,20 +188,52 @@ private[ui] class AllJobsPage(parent: JobsTab, store: AppStatusStore) extends We
val eventArrayAsStr =
(jobEventJsonAsStrSeq ++ executorEventJsonAsStrSeq).mkString("[", ",", "]")
- <span class="expand-application-timeline">
- <span class="expand-application-timeline-arrow arrow-closed"></span>
- <a data-toggle="tooltip" title={ToolTips.JOB_TIMELINE} data-placement="top">
- Event Timeline
- </a>
- </span> ++
- <div id="application-timeline" class="collapsed">
- <div class="control-panel">
- <div id="application-timeline-zoom-lock">
- <input type="checkbox"></input>
- <span>Enable zooming</span>
+ if (totalPages > 0) {
+ <span class="expand-application-timeline">
+ <span class="expand-application-timeline-arrow arrow-closed"></span>
+ <a data-toggle="tooltip" title={ToolTips.JOB_TIMELINE} data-placement="top">
+ Event Timeline
+ </a>
+ </span> ++
+ <div id="application-timeline" class="collapsed">
+ <div class="control-panel">
+ <div id="application-timeline-zoom-lock">
+ <input type="checkbox"></input>
+ <span>Enable zooming</span>
+ </div>
+ <div>
+ <form id={s"form-event-timeline-page"}
+ method="get"
+ action=""
+ class="form-inline justify-content-end"
+ style="width: 50%; margin-left: auto; margin-bottom: 0px;">
Review comment:
Thanks. I'll consider it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643057633
@gengliangwang Yes, I've noticed that. [The performance issue of `vis-timeline`](https://github.com/visjs/vis-timeline/issues/379) happens for newer version of `vis.js`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643070561
> Even if no performance issue exists, lots of items rendered in one page can be too noisy.
OK, how about we merge #28806 to 3.0/2.4 first.
And start the pagination from 3.1 if you insist?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-714092922
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-642979886
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang edited a comment on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
gengliangwang edited a comment on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643070561
> Even if no performance issue exists, lots of items rendered in one page can be too noisy.
OK, how about we merge #28806 to 3.0/2.4 first.
And start the pagination feature from 3.1 if you insist?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643576377
> I think we should make the two pagination sections consistent
The upper text fields are for timeline, while the lower ones are for the table so I think they should be independent each other.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-642923940
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643576860
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643599702
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643582554
retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-642979886
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643063667
> 1. if there are many stages in one job, the perf issue still exists
> 2. the two paginations in one page seem weird.
For 1), AllJobsPage is not affected even if a job has many stages isn't it? JobPage can be affect but we can apply the same solution. For 2), Yes, it's a little bit weird but the similar solution already exists in StagePage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643063667
> 1. if there are many stages in one job, the perf issue still exists
> 2. the two paginations in one page seem weird.
For 1), AllJobsPage is not affected even if a job has many stages isn't it? JobPage can be affect but we can apply the same solution. For 2), Yes, it's a little bit weird but the similar solution already exists in StagePage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643057633
@gengliangwang Yes, I've noticed that. The performance issue of `vis-timeline`https://github.com/visjs/vis-timeline/issues/379 happen for newer version of `vis.js`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #28803:
URL: https://github.com/apache/spark/pull/28803#discussion_r451280315
##########
File path: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala
##########
@@ -184,20 +188,52 @@ private[ui] class AllJobsPage(parent: JobsTab, store: AppStatusStore) extends We
val eventArrayAsStr =
(jobEventJsonAsStrSeq ++ executorEventJsonAsStrSeq).mkString("[", ",", "]")
- <span class="expand-application-timeline">
- <span class="expand-application-timeline-arrow arrow-closed"></span>
- <a data-toggle="tooltip" title={ToolTips.JOB_TIMELINE} data-placement="top">
- Event Timeline
- </a>
- </span> ++
- <div id="application-timeline" class="collapsed">
- <div class="control-panel">
- <div id="application-timeline-zoom-lock">
- <input type="checkbox"></input>
- <span>Enable zooming</span>
+ if (totalPages > 0) {
+ <span class="expand-application-timeline">
+ <span class="expand-application-timeline-arrow arrow-closed"></span>
+ <a data-toggle="tooltip" title={ToolTips.JOB_TIMELINE} data-placement="top">
+ Event Timeline
+ </a>
+ </span> ++
+ <div id="application-timeline" class="collapsed">
+ <div class="control-panel">
+ <div id="application-timeline-zoom-lock">
+ <input type="checkbox"></input>
+ <span>Enable zooming</span>
+ </div>
+ <div>
+ <form id={s"form-event-timeline-page"}
+ method="get"
+ action=""
+ class="form-inline justify-content-end"
+ style="width: 50%; margin-left: auto; margin-bottom: 0px;">
Review comment:
nit: shall we move the style to webui.css?
##########
File path: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala
##########
@@ -184,20 +188,52 @@ private[ui] class AllJobsPage(parent: JobsTab, store: AppStatusStore) extends We
val eventArrayAsStr =
(jobEventJsonAsStrSeq ++ executorEventJsonAsStrSeq).mkString("[", ",", "]")
- <span class="expand-application-timeline">
- <span class="expand-application-timeline-arrow arrow-closed"></span>
- <a data-toggle="tooltip" title={ToolTips.JOB_TIMELINE} data-placement="top">
- Event Timeline
- </a>
- </span> ++
- <div id="application-timeline" class="collapsed">
- <div class="control-panel">
- <div id="application-timeline-zoom-lock">
- <input type="checkbox"></input>
- <span>Enable zooming</span>
+ if (totalPages > 0) {
+ <span class="expand-application-timeline">
+ <span class="expand-application-timeline-arrow arrow-closed"></span>
+ <a data-toggle="tooltip" title={ToolTips.JOB_TIMELINE} data-placement="top">
+ Event Timeline
+ </a>
+ </span> ++
+ <div id="application-timeline" class="collapsed">
+ <div class="control-panel">
+ <div id="application-timeline-zoom-lock">
+ <input type="checkbox"></input>
+ <span>Enable zooming</span>
+ </div>
+ <div>
+ <form id={s"form-event-timeline-page"}
+ method="get"
+ action=""
+ class="form-inline justify-content-end"
+ style="width: 50%; margin-left: auto; margin-bottom: 0px;">
+ <label>Jobs:
+ {totalJobs}
+ .
+ {totalPages}
+ Pages. Jump to</label>
+ <input type="text"
+ name="jobs.eventTimelinePageNumber"
+ id={s"form-event-timeline-page-no"}
Review comment:
Nit: I find similar code in StagePage.scala. But why do we need `{s".."}` here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #28803:
URL: https://github.com/apache/spark/pull/28803
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643583329
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643059905
Let me create a PR for downgrading to 4.21.0 now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643075974
> OK, how about we merge #28806 to 3.0/2.4 first.
> And start the pagination feature from 3.1 if you insist?
I agree. I'll check that PR soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643599702
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643576740
**[Test build #123965 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123965/testReport)** for PR 28803 at commit [`0270bb9`](https://github.com/apache/spark/commit/0270bb9904b881be981f274db17736feda506728).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-643059040
So, I am actually -1 in this solution, for two reasons:
1. if there are many stages in one job, the perf issue still exists
2. the two paginations in one page seem weird.
I tried a different version 4.21.0 from https://cdnjs.com/libraries/vis
The infinite drawing issue seems better if the zoom is not enabled.
How about we changing to that version? or, just reverting https://github.com/apache/spark/pull/28192?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-642923349
**[Test build #123864 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123864/testReport)** for PR 28803 at commit [`90b132b`](https://github.com/apache/spark/commit/90b132b23c98437b277ef4752612ad2661c5ae84).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-642923940
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-655260973
cc: @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-642941206
@sarutak Thanks for the quick fix. I try on my local setup and it works.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28803:
URL: https://github.com/apache/spark/pull/28803#issuecomment-655279892
**[Test build #125295 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125295/testReport)** for PR 28803 at commit [`0270bb9`](https://github.com/apache/spark/commit/0270bb9904b881be981f274db17736feda506728).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org