You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2023/02/28 05:11:07 UTC
[Impala-ASF-CR] IMPALA-11944: Add SLES 15 support
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19556
Change subject: IMPALA-11944: Add SLES 15 support
......................................................................
IMPALA-11944: Add SLES 15 support
Updates IMPALA_TOOLCHAIN_BUILD_ID to a native-toolchain build that
includes SLES 15 support and adds OsMapping for SLES 15.
Testing:
- built with impala-toolchain-sles15 container image from
native-toolchain, which includes Python 2 and Java 8 SDK from OpenSUSE
Leap.
Change-Id: I4015b695862abc6eb901a857cc1c444aff1bbe24
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
2 files changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/19556/1
--
To view, visit http://gerrit.cloudera.org:8080/19556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4015b695862abc6eb901a857cc1c444aff1bbe24
Gerrit-Change-Number: 19556
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-11944: Add SLES 15 support
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19556 )
Change subject: IMPALA-11944: Add SLES 15 support
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12498/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4015b695862abc6eb901a857cc1c444aff1bbe24
Gerrit-Change-Number: 19556
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Feb 2023 23:17:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11944: Add SLES 15 support
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Laszlo Gaal, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19556
to look at the new patch set (#3).
Change subject: IMPALA-11944: Add SLES 15 support
......................................................................
IMPALA-11944: Add SLES 15 support
Updates IMPALA_TOOLCHAIN_BUILD_ID to a native-toolchain build that
includes SLES 15 support and adds OsMapping for SLES 15.
Testing:
- built with impala-toolchain-sles15 container image from
native-toolchain, which includes Python 2 and Java 8 SDK from OpenSUSE
Leap.
Change-Id: I4015b695862abc6eb901a857cc1c444aff1bbe24
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
2 files changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/19556/3
--
To view, visit http://gerrit.cloudera.org:8080/19556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4015b695862abc6eb901a857cc1c444aff1bbe24
Gerrit-Change-Number: 19556
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-11944: Add SLES 15 support
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19556 )
Change subject: IMPALA-11944: Add SLES 15 support
......................................................................
Patch Set 3: Code-Review+2
Carrying +2 for build number (but not ref) update.
--
To view, visit http://gerrit.cloudera.org:8080/19556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4015b695862abc6eb901a857cc1c444aff1bbe24
Gerrit-Change-Number: 19556
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Feb 2023 22:58:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11944: Add SLES 15 support
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19556 )
Change subject: IMPALA-11944: Add SLES 15 support
......................................................................
IMPALA-11944: Add SLES 15 support
Updates IMPALA_TOOLCHAIN_BUILD_ID to a native-toolchain build that
includes SLES 15 support and adds OsMapping for SLES 15.
Testing:
- built with impala-toolchain-sles15 container image from
native-toolchain, which includes Python 2 and Java 8 SDK from OpenSUSE
Leap.
Change-Id: I4015b695862abc6eb901a857cc1c444aff1bbe24
Reviewed-on: http://gerrit.cloudera.org:8080/19556
Reviewed-by: Michael Smith <mi...@cloudera.com>
Tested-by: Michael Smith <mi...@cloudera.com>
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
2 files changed, 3 insertions(+), 1 deletion(-)
Approvals:
Michael Smith: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/19556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4015b695862abc6eb901a857cc1c444aff1bbe24
Gerrit-Change-Number: 19556
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-11944: Add SLES 15 support
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19556 )
Change subject: IMPALA-11944: Add SLES 15 support
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19556/2/bin/impala-config.sh
File bin/impala-config.sh:
http://gerrit.cloudera.org:8080/#/c/19556/2/bin/impala-config.sh@84
PS2, Line 84: export IMPALA_TOOLCHAIN_BUILD_ID=19-b144ba77b5
This was built using a playground builder, going to produce one using the production builder which should have a sequence higher than 237.
--
To view, visit http://gerrit.cloudera.org:8080/19556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4015b695862abc6eb901a857cc1c444aff1bbe24
Gerrit-Change-Number: 19556
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Feb 2023 19:00:02 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11944: Add SLES 15 support
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19556 )
Change subject: IMPALA-11944: Add SLES 15 support
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9080/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/19556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4015b695862abc6eb901a857cc1c444aff1bbe24
Gerrit-Change-Number: 19556
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Feb 2023 17:30:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11944: Add SLES 15 support
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19556 )
Change subject: IMPALA-11944: Add SLES 15 support
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4015b695862abc6eb901a857cc1c444aff1bbe24
Gerrit-Change-Number: 19556
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Feb 2023 22:38:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11944: Add SLES 15 support
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19556 )
Change subject: IMPALA-11944: Add SLES 15 support
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12477/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4015b695862abc6eb901a857cc1c444aff1bbe24
Gerrit-Change-Number: 19556
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Feb 2023 05:30:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11944: Add SLES 15 support
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19556 )
Change subject: IMPALA-11944: Add SLES 15 support
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4015b695862abc6eb901a857cc1c444aff1bbe24
Gerrit-Change-Number: 19556
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Mar 2023 04:52:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11944: Add SLES 15 support
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/19556 )
Change subject: IMPALA-11944: Add SLES 15 support
......................................................................
Patch Set 2:
> Patch Set 2:
>
> (1 comment)
I'm not sure you need to bother: the second part of the build ID (the short git hash from the native-toolchain repo) is much more important for reproducibility, and that points to the right place: the master branch of github.com/cloudera/native-toolchain.
--
To view, visit http://gerrit.cloudera.org:8080/19556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4015b695862abc6eb901a857cc1c444aff1bbe24
Gerrit-Change-Number: 19556
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Feb 2023 19:12:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11944: Add SLES 15 support
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/19556 )
Change subject: IMPALA-11944: Add SLES 15 support
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4015b695862abc6eb901a857cc1c444aff1bbe24
Gerrit-Change-Number: 19556
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Feb 2023 19:12:47 +0000
Gerrit-HasComments: No