You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "pbacsko (via GitHub)" <gi...@apache.org> on 2023/06/29 18:21:09 UTC
[GitHub] [yunikorn-core] pbacsko opened a new pull request, #586: [YUNIKORN-1846] Rewrite event verification in application_test.go
pbacsko opened a new pull request, #586:
URL: https://github.com/apache/yunikorn-core/pull/586
### What is this PR for?
Application events are checked in complicated test cases in `application_test.go`.
Move the testing logic to new test cases.
### What type of PR is it?
* [ ] - Bug Fix
* [x] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1846
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] pbacsko closed pull request #586: [YUNIKORN-1846] Rewrite event verification in application_test.go
Posted by "pbacsko (via GitHub)" <gi...@apache.org>.
pbacsko closed pull request #586: [YUNIKORN-1846] Rewrite event verification in application_test.go
URL: https://github.com/apache/yunikorn-core/pull/586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] pbacsko commented on pull request #586: [YUNIKORN-1846] Rewrite event verification in application_test.go
Posted by "pbacsko (via GitHub)" <gi...@apache.org>.
pbacsko commented on PR #586:
URL: https://github.com/apache/yunikorn-core/pull/586#issuecomment-1613609942
This improvement is necessary for #581
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #586: [YUNIKORN-1846] Rewrite event verification in application_test.go
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #586:
URL: https://github.com/apache/yunikorn-core/pull/586#issuecomment-1613607740
## [Codecov](https://app.codecov.io/gh/apache/yunikorn-core/pull/586?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#586](https://app.codecov.io/gh/apache/yunikorn-core/pull/586?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (b9b81d6) into [master](https://app.codecov.io/gh/apache/yunikorn-core/commit/9bc3a5e4d499fecbdfdaf6402201cba5490d5ab0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (9bc3a5e) will **increase** coverage by `0.45%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head b9b81d6 differs from pull request most recent head ea8a0ba. Consider uploading reports for the commit ea8a0ba to get more accurate results
```diff
@@ Coverage Diff @@
## master #586 +/- ##
==========================================
+ Coverage 76.41% 76.86% +0.45%
==========================================
Files 74 75 +1
Lines 12212 12291 +79
==========================================
+ Hits 9332 9448 +116
+ Misses 2569 2529 -40
- Partials 311 314 +3
```
| [Impacted Files](https://app.codecov.io/gh/apache/yunikorn-core/pull/586?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/application.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/586?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `68.39% <100.00%> (+2.85%)` | :arrow_up: |
| [pkg/scheduler/objects/application\_events.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/586?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uX2V2ZW50cy5nbw==) | `94.64% <100.00%> (-5.36%)` | :arrow_down: |
... and [3 files with indirect coverage changes](https://app.codecov.io/gh/apache/yunikorn-core/pull/586/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org