You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/10/14 13:55:10 UTC
[GitHub] [fineract] IOhacker opened a new pull request #1892: Upgrade JaCoco version to 0.8.7 for suporting JDK 17
IOhacker opened a new pull request #1892:
URL: https://github.com/apache/fineract/pull/1892
## Description
With the upgrade to JaCoco 0.8.7 the Fineract Code Base will be prepared to be tested with the new JDK 17 which extends the support until 2026 it is related to https://issues.apache.org/jira/browse/FINERACT-1407
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [X] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [X] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [X] Create/update unit or integration tests for verifying the changes made.
- [X] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [X] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [X] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum edited a comment on pull request #1892: Upgrade JaCoco version to 0.8.7 for suporting JDK 17
Posted by GitBox <gi...@apache.org>.
awasum edited a comment on pull request #1892:
URL: https://github.com/apache/fineract/pull/1892#issuecomment-944681487
Reopening now wont solve the problem as we can have a max of 100 pulls from DockerHub within a 6 hour period.. See: https://www.docker.com/increase-rate-limits
So we have to wait tomorrow to close and reopen this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1892: Upgrade JaCoco version to 0.8.7 for suporting JDK 17
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1892:
URL: https://github.com/apache/fineract/pull/1892#issuecomment-944477230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] IOhacker commented on pull request #1892: Upgrade JaCoco version to 0.8.7 for suporting JDK 17
Posted by GitBox <gi...@apache.org>.
IOhacker commented on pull request #1892:
URL: https://github.com/apache/fineract/pull/1892#issuecomment-945041431
It has passed all the tests. Can it be merged? I will continue to work on
JDK 17.
Regards
El vie, 15 oct 2021 a las 23:24, Benura Abeywardena (<
***@***.***>) escribió:
> Reopening now wont solve the problem as we can have a max of 100 pulls
> from DockerHub within a 6 hour period.. See:
> https://www.docker.com/increase-rate-limits
>
> So we have to wait tomorrow to close and reopen this PR.
>
> Yeah
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/fineract/pull/1892#issuecomment-944853609>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ALD2ZAQXLZN3HETJ4KOM6DLUHD5ATANCNFSM5F7XGXEQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] IOhacker closed pull request #1892: Upgrade JaCoco version to 0.8.7 for suporting JDK 17
Posted by GitBox <gi...@apache.org>.
IOhacker closed pull request #1892:
URL: https://github.com/apache/fineract/pull/1892
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan commented on pull request #1892: Upgrade JaCoco version to 0.8.7 for suporting JDK 17
Posted by GitBox <gi...@apache.org>.
BLasan commented on pull request #1892:
URL: https://github.com/apache/fineract/pull/1892#issuecomment-944665959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] IOhacker merged pull request #1892: Upgrade JaCoco version to 0.8.7 for suporting JDK 17
Posted by GitBox <gi...@apache.org>.
IOhacker merged pull request #1892:
URL: https://github.com/apache/fineract/pull/1892
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] IOhacker commented on pull request #1892: Upgrade JaCoco version to 0.8.7 for suporting JDK 17
Posted by GitBox <gi...@apache.org>.
IOhacker commented on pull request #1892:
URL: https://github.com/apache/fineract/pull/1892#issuecomment-944471838
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1892: Upgrade JaCoco version to 0.8.7 for suporting JDK 17
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1892:
URL: https://github.com/apache/fineract/pull/1892#issuecomment-945045825
Can you squash the commits to one (with appropriate description) please? I'll merge once done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org