Re: [PR] Use Kafka Admin client to Fetch offsets instead of Kafka Consumer [pinot]

["KKcorps (via GitHub)" <gi...@apache.org>]

KKcorps commented on code in PR #15641:
URL: https://github.com/apache/pinot/pull/15641#discussion_r2071189588


##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -1323,6 +1323,9 @@ private void closePartitionMetadataProvider() {
         _partitionMetadataProvider.close();
       } catch (Exception e) {
         _segmentLogger.warn("Could not close stream metadata provider", e);
+      } finally {
+        // Clear reference so future offset fetches recreate a fresh provider
+        _partitionMetadataProvider = null;

Review Comment:
   Yes, removing this. I am going to tackle this in a seperate PR along with other log related issues. 
   Keeping this one only for migration to kafka admin client



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org