[GitHub] [trafficserver] brbzull0 edited a comment on issue #7103: 8.0.x (and possibly others) does not reset param to default when removed from records

[GitBox <gi...@apache.org>]

brbzull0 edited a comment on issue #7103:
URL: https://github.com/apache/trafficserver/issues/7103#issuecomment-976435244


   > I think the best way to help deal with this is add a `revert` option to `traffic_ctl` that would set a specific configuration variable to the built in default. Detecting an omission from "records.config" would be a bit challenging.
   
   +1 for the revert option.
   
   But in parallel:
   
   It seems to me that someone was thinking about keeping track of the status of the new` records.config `content:
   https://github.com/apache/trafficserver/blob/57015b77d45acc7bccea5295a26168faa1d6ef52/lib/records/RecConfigParse.cc#L250
   
   this is never used in ATS though,  it' never gets reset, so won't help tracking new content unless it's allocated in the function stack(or clean it before use), anyway I think the intention was for tracking mismatches between the old and new content.
   @SolidWallOfCode Would it make sense having this container local and check mismatches against  `g_records_ht` ? then just set the default? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org