You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2015/06/07 04:31:02 UTC
Review Request 35185: Oozie Web Alert Has Wrong http Property In Alert
Definition
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35185/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez and Nate Cole.
Bugs: AMBARI-11749
https://issues.apache.org/jira/browse/AMBARI-11749
Repository: ambari
Description
-------
Deployed a clean HDP 2.2 cluster and noticed a 404 NOT FOUND alert for Oozie. The alert definition has the following:
{code}
"http": "{{oozie-site/oozie.base.url}}/oozie/?user.name=oozie",
{code}
However, {{oozie/site/oozie.base.url}} is {{http://server/oozie}} which makes the alert look for {{http://server/oozie/oozie?usern.name=oozie}} instead of {{http://server/oozie?user.name=oozie}}
Either the alert definitions (in both 4.* and 5.* OOZIE folders) needs to change or the base url property needs to change.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java c337dec
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java 76cd0fc
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/alerts.json a14f782
ambari-server/src/main/resources/common-services/OOZIE/5.0.0.2.3/alerts.json d75d1b2
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/OOZIE/alerts.json e57a4f8
Diff: https://reviews.apache.org/r/35185/diff/
Testing
-------
mvn clean test
Verified new oozie alert definition does not throw a 404
Thanks,
Jonathan Hurley
Re: Review Request 35185: Oozie Web Alert Has Wrong http Property In
Alert Definition
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35185/
-----------------------------------------------------------
(Updated June 7, 2015, 9:34 a.m.)
Review request for Ambari, Alejandro Fernandez and Nate Cole.
Changes
-------
Parameterized oozie user name.
Bugs: AMBARI-11749
https://issues.apache.org/jira/browse/AMBARI-11749
Repository: ambari
Description
-------
Deployed a clean HDP 2.2 cluster and noticed a 404 NOT FOUND alert for Oozie. The alert definition has the following:
{code}
"http": "{{oozie-site/oozie.base.url}}/oozie/?user.name=oozie",
{code}
However, {{oozie/site/oozie.base.url}} is {{http://server/oozie}} which makes the alert look for {{http://server/oozie/oozie?usern.name=oozie}} instead of {{http://server/oozie?user.name=oozie}}
Either the alert definitions (in both 4.* and 5.* OOZIE folders) needs to change or the base url property needs to change.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java c337dec
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java 76cd0fc
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/alerts.json a14f782
ambari-server/src/main/resources/common-services/OOZIE/5.0.0.2.3/alerts.json d75d1b2
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/OOZIE/alerts.json e57a4f8
Diff: https://reviews.apache.org/r/35185/diff/
Testing
-------
mvn clean test
Verified new oozie alert definition does not throw a 404
Thanks,
Jonathan Hurley
Re: Review Request 35185: Oozie Web Alert Has Wrong http Property In
Alert Definition
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On June 7, 2015, 9:09 a.m., Nate Cole wrote:
> > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/alerts.json, line 14
> > <https://reviews.apache.org/r/35185/diff/1/?file=980454#file980454line14>
> >
> > I realize not a part of this jira (and won't hold it up), but should user.name=oozie be user.name=\{\{oozie-env/oozie_user\}\} ?
Hmmm ... that's a good point. The user.name=oozie was a recent addition. I can change this to include the parameterized name as well.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35185/#review86963
-----------------------------------------------------------
On June 6, 2015, 10:31 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35185/
> -----------------------------------------------------------
>
> (Updated June 6, 2015, 10:31 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
>
>
> Bugs: AMBARI-11749
> https://issues.apache.org/jira/browse/AMBARI-11749
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Deployed a clean HDP 2.2 cluster and noticed a 404 NOT FOUND alert for Oozie. The alert definition has the following:
>
> {code}
> "http": "{{oozie-site/oozie.base.url}}/oozie/?user.name=oozie",
> {code}
>
> However, {{oozie/site/oozie.base.url}} is {{http://server/oozie}} which makes the alert look for {{http://server/oozie/oozie?usern.name=oozie}} instead of {{http://server/oozie?user.name=oozie}}
>
> Either the alert definitions (in both 4.* and 5.* OOZIE folders) needs to change or the base url property needs to change.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java c337dec
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java 76cd0fc
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/alerts.json a14f782
> ambari-server/src/main/resources/common-services/OOZIE/5.0.0.2.3/alerts.json d75d1b2
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/OOZIE/alerts.json e57a4f8
>
> Diff: https://reviews.apache.org/r/35185/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> Verified new oozie alert definition does not throw a 404
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 35185: Oozie Web Alert Has Wrong http Property In
Alert Definition
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35185/#review86963
-----------------------------------------------------------
Ship it!
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/alerts.json
<https://reviews.apache.org/r/35185/#comment139181>
I realize not a part of this jira (and won't hold it up), but should user.name=oozie be user.name=\{\{oozie-env/oozie_user\}\} ?
- Nate Cole
On June 6, 2015, 10:31 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35185/
> -----------------------------------------------------------
>
> (Updated June 6, 2015, 10:31 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
>
>
> Bugs: AMBARI-11749
> https://issues.apache.org/jira/browse/AMBARI-11749
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Deployed a clean HDP 2.2 cluster and noticed a 404 NOT FOUND alert for Oozie. The alert definition has the following:
>
> {code}
> "http": "{{oozie-site/oozie.base.url}}/oozie/?user.name=oozie",
> {code}
>
> However, {{oozie/site/oozie.base.url}} is {{http://server/oozie}} which makes the alert look for {{http://server/oozie/oozie?usern.name=oozie}} instead of {{http://server/oozie?user.name=oozie}}
>
> Either the alert definitions (in both 4.* and 5.* OOZIE folders) needs to change or the base url property needs to change.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java c337dec
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java 76cd0fc
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/alerts.json a14f782
> ambari-server/src/main/resources/common-services/OOZIE/5.0.0.2.3/alerts.json d75d1b2
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/OOZIE/alerts.json e57a4f8
>
> Diff: https://reviews.apache.org/r/35185/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> Verified new oozie alert definition does not throw a 404
>
>
> Thanks,
>
> Jonathan Hurley
>
>