[GitHub] nifi-minifi-cpp pull request #253: MINIFICPP-388 Added missing controller/ a...

[achristianson <gi...@git.apache.org>]

GitHub user achristianson opened a pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/253

    MINIFICPP-388 Added missing controller/ and LibExample/ dirs for dock…

    …er build
    
    Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced
         in the commit message?
    
    - [x] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [x] If applicable, have you updated the LICENSE file?
    - [x] If applicable, have you updated the NOTICE file?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-388

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi-cpp/pull/253.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #253
    
----
commit 414f5e8e1474b115b6e72055c83a9163c9bb74cc
Author: Andrew I. Christianson <ac...@...>
Date:   2018-01-31T17:48:25Z

    MINIFICPP-388 Added missing controller/ and LibExample/ dirs for docker build

----


---

[GitHub] nifi-minifi-cpp pull request #253: MINIFICPP-388 Added missing controller/ a...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/nifi-minifi-cpp/pull/253


---

[GitHub] nifi-minifi-cpp issue #253: MINIFICPP-388 Added missing controller/ and LibE...

[achristianson <gi...@git.apache.org>]

Github user achristianson commented on the issue:

    https://github.com/apache/nifi-minifi-cpp/pull/253
  
    It could be, but that would be a redesign of how it's currently working. I think that should be added as a separate redesign ticket rather than this bugfix.


---