You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/19 10:51:14 UTC
[GitHub] [spark] panbingkun opened a new pull request, #38725: [SPARK-41182][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_1102
panbingkun opened a new pull request, #38725:
URL: https://github.com/apache/spark/pull/38725
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
Pass GA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #38725: [SPARK-41182][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_1102
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #38725:
URL: https://github.com/apache/spark/pull/38725#issuecomment-1326092797
+1, LGTM. Merging to master.
Thank you, @panbingkun.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #38725: [SPARK-41182][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_1102
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #38725:
URL: https://github.com/apache/spark/pull/38725#issuecomment-1321183950
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #38725: [SPARK-41182][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_1102
Posted by GitBox <gi...@apache.org>.
panbingkun commented on code in PR #38725:
URL: https://github.com/apache/spark/pull/38725#discussion_r1027386994
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1326,6 +1326,11 @@
"grouping()/grouping_id() can only be used with GroupingSets/Cube/Rollup"
]
},
+ "UNSUPPORTED_LITERAL_FOR_SOURCE_TYPE" : {
+ "message" : [
+ "Literals of the type <field> are currently not supported for the <sourceDataType> type."
Review Comment:
OK, Let me to do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #38725: [SPARK-41182][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_1102
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #38725:
URL: https://github.com/apache/spark/pull/38725#discussion_r1030079292
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -656,6 +656,11 @@
],
"sqlState" : "42000"
},
+ "INVALID_EXTRACT_FIELD" : {
+ "message" : [
+ "Literals of the type <field> are currently not supported for the <sourceDataType> type."
Review Comment:
Could you make the error message more clear and precise. Let's talk specifically about the invalid extract field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #38725: [SPARK-41182][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_1102
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #38725: [SPARK-41182][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_1102
URL: https://github.com/apache/spark/pull/38725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #38725: [SPARK-41182][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_1102
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #38725:
URL: https://github.com/apache/spark/pull/38725#discussion_r1027319785
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1326,6 +1326,11 @@
"grouping()/grouping_id() can only be used with GroupingSets/Cube/Rollup"
]
},
+ "UNSUPPORTED_LITERAL_FOR_SOURCE_TYPE" : {
+ "message" : [
+ "Literals of the type <field> are currently not supported for the <sourceDataType> type."
Review Comment:
Looking at where the error comes from:
1. https://github.com/apache/spark/blob/51e4c2cc55aa01f07b28b1cd807b553f8729075d/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/intervalExpressions.scala#L159
2. https://github.com/apache/spark/blob/b14da8b1b65d9f00f49fab87f738715089bc43e8/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala#L2795
, the error message and error class name confuse slightly. The error is mostly about an extract field. How about error class name:
`INVALID_EXTRACT_FIELD`
Also cc @srielau
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #38725: [SPARK-41182][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_1102
Posted by GitBox <gi...@apache.org>.
panbingkun commented on code in PR #38725:
URL: https://github.com/apache/spark/pull/38725#discussion_r1030392540
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -656,6 +656,11 @@
],
"sqlState" : "42000"
},
+ "INVALID_EXTRACT_FIELD" : {
+ "message" : [
+ "Literals of the type <field> are currently not supported for the <sourceDataType> type."
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org