[GitHub] [datasketches-cpp] AlexanderSaydakov commented on a diff in pull request #313: comparator instance support

[GitBox <gi...@apache.org>]

AlexanderSaydakov commented on code in PR #313:
URL: https://github.com/apache/datasketches-cpp/pull/313#discussion_r1008647031


##########
common/test/quantile_sketch_sorted_view_test.cpp:
##########
@@ -22,12 +22,15 @@
 #include <vector>
 #include <utility>
 
+#include <iostream>
+
 #include "quantile_sketch_sorted_view.hpp"
 
 namespace datasketches {
 
 TEST_CASE("set 0", "sorted view") {
-  auto view = quantile_sketch_sorted_view<float, std::less<float>, std::allocator<float>>(1, std::allocator<float>());
+  std::cout << "sizeof(sorted_view<float>=" << sizeof(quantile_sketch_sorted_view<float, std::less<float>, std::allocator<float>>) << '\n';

Review Comment:
   yes, will do



##########
quantiles/test/quantiles_sketch_test.cpp:
##########
@@ -894,7 +905,7 @@ TEST_CASE("quantiles sketch", "[quantiles_sketch]") {
     const int n = 403;
     quantiles_sketch<double> sk_double(k);
     
-    quantiles_sketch<float> sk_float(k, sk_double.get_allocator());
+    quantiles_sketch<float> sk_float(k);

Review Comment:
   ok



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org