[GitHub] [airflow] potiuk commented on a change in pull request #19639: Remove `allowed_conn_types` from SqlSensor

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #19639:
URL: https://github.com/apache/airflow/pull/19639#discussion_r751117723



##########
File path: airflow/sensors/sql.py
##########
@@ -70,27 +71,13 @@ def __init__(
 
     def _get_hook(self):
         conn = BaseHook.get_connection(self.conn_id)
-
-        allowed_conn_type = {
-            'google_cloud_platform',

Review comment:
       Note: apparently there was a mistake there - > we changed the type of connection for BigQueryHook to be 'gcpbigquery` (historically it used to be 'google_cloud_platform' so this would not work for BigQuery :( - but after that change it will work fine as BigQueryHook derives from DBApi




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org