You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/09/22 11:45:47 UTC
[GitHub] [ozone] dombizita opened a new pull request #2671: HDDS-5695 Review ZK and Curator dependencies, and get rid of them.
dombizita opened a new pull request #2671:
URL: https://github.com/apache/ozone/pull/2671
This reverts commit e8b15f4223fe4ac225c41fda832591dedb32b523.
## What changes were proposed in this pull request?
This pull request is reverting the changes in HDDS-5695. Previously the Zookeeper and Curator dependencies were deleted, as we thought they were unnecessary. But later we found out, that in the CI the server couldn't start, because the it is unable to initialize WebAppContext. It happened because the DelegationTokenAuthenticationFilter class is using Zookeeper through curator, as the class is using delegation tokens and the token details are stored in ZooKeeper. So the ZK and the Curator dependencies are needed.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5695
## How was this patch tested?
Built it without problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] fapifta merged pull request #2671: HDDS-5695 Review ZK and Curator dependencies, and get rid of them.
Posted by GitBox <gi...@apache.org>.
fapifta merged pull request #2671:
URL: https://github.com/apache/ozone/pull/2671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] fapifta commented on pull request #2671: HDDS-5695 Review ZK and Curator dependencies, and get rid of them.
Posted by GitBox <gi...@apache.org>.
fapifta commented on pull request #2671:
URL: https://github.com/apache/ozone/pull/2671#issuecomment-928068280
Hi Zita,
thank you for posting the PR, and pointing out the problem with the runtime without these dependencies at the moment.
During our discussion we revealed that the DelegationTokenAuthenticationFilter the code is extending from is coming from hadoop, and it is not that easy to remove the dependency on it without further testing. In order to unblock CI, this change is necessary so, +1 to have these back temporarily and deal with them later on.
I am merging the change to the branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org