[GitHub] [cloudstack] fermosan commented on pull request #6550: Emc networker b&r

[GitBox <gi...@apache.org>]

fermosan commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1301592982

   > 
   
   
   
   > ping @fermosan you see any chance to address @rohityadavcloud 's remaining comments?
   
   Yes. @DaanHoogland 
   Updates:
      if (guestOsMapping == null || hostVo == null)  will be reverted in a coming patch
   
   I am trying to see if we can use the Script.findScript().  I cannot find a way to make this work. The function is called on the management server side and the script cannot be found since it exists on the client.
   Furthermore in the development environment the lookup path is under the local development directories. 
   There is now straight way to get "kvm.script.dir" or "scripts.path" from environ since configure for super is not there. 
   If there is no way for this to work the full path will be used there.  Any ideas ?
   
   I am also working on eliminating the need for sudo execution on the KVM host side (needs some work/testing and more conf in 
   the EMC networker side). If successful, i will commit here and update the documentation pull as well to reflect that.
   
   For the [ui/public/config.json] I will revert the changes and match main in a coming patch. 
   
   Finally for the comments about 
   
   int minCpuCores = virtualMachineTo.getCpus();
   long minMemory = virtualMachineTo.getMinRam();
   
   The code was there beforehand and as far as I can see it is not used by any other components. It is however used in the tests. I am not sure what is supposed to do and which components are supposed to call it if any. Any inputs ? How we going to proceed on that ? My guess is that it has to do something with the computer offerings. Can those be null under any circumstance ? 
   
   Maybe @nvazquez  has some input for the above. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org