You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by "Ralph Goers (JIRA)" <ji...@apache.org> on 2013/04/08 07:35:15 UTC
[jira] [Commented] (LOG4J2-173) BurstFilter does not honour level
[ https://issues.apache.org/jira/browse/LOG4J2-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625156#comment-13625156 ]
Ralph Goers commented on LOG4J2-173:
------------------------------------
I've looked at the BurstFilterTest and it seems to test things properly and the unit test runs without errors. Can you provide a test that you believe should work that doesn't?
> BurstFilter does not honour level
> ---------------------------------
>
> Key: LOG4J2-173
> URL: https://issues.apache.org/jira/browse/LOG4J2-173
> Project: Log4j 2
> Issue Type: Bug
> Components: Filters
> Affects Versions: 2.0-beta4
> Reporter: Henry Clout
>
> I've been getting info (and below) logging out of the BurstFilter despite it being set to warn. The problem seems to be in the filter method, the test :
> if (this.level.isAtLeastAsSpecificAs(level)) {
> ... seems to be the wrong way around.
> I changed the method locally to be:
> private Result filter(final Level level) {
> if (level.isAtLeastAsSpecificAs(this.level)) {
> LogDelay delay = history.poll();
> while (delay != null) {
> available.add(delay);
> delay = history.poll();
> }
> delay = available.poll();
> if (delay != null) {
> delay.setDelay(burstInterval);
> history.add(delay);
> return onMatch;
> }
> return onMismatch;
> }
> return onMismatch;
> }
> Which seems to have the desired results.
> Does this make sense?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org