You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by jo...@apache.org on 2016/06/13 14:02:02 UTC

zeppelin git commit: [MINOR] Removed classloaderInterpreter on RemoteInterpreterServer

Repository: zeppelin
Updated Branches:
  refs/heads/master 7e1ad5b14 -> c5a7c77a0


[MINOR] Removed classloaderInterpreter on RemoteInterpreterServer

### What is this PR for?
Removed usage of ClassloaderInterpreter while RemoteInterpreter is being created.

### What type of PR is it?
[Refactoring]

### Todos
* [x] - Fixed the codes for not using ClassloaderInterpreter

### What is the Jira issue?
N/A

### How should this be tested?
This PR should not change any user experience

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Classloader in RemoteInterpreter uses system classloader, thus there's no reason why interpreter is wrapped by Classloader

Author: Jongyoul Lee <jo...@gmail.com>

Closes #990 from jongyoul/minor-unwrap-classloaderinterpreter-in-remoteinterpreterserver and squashes the following commits:

212368f [Jongyoul Lee] Removed classloaderInterpreter on RemoteInterpreterServer Classloader in interpreter uses system classloader, thus there's no reason why interpreter is wrapped by Classloader


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/c5a7c77a
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/c5a7c77a
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/c5a7c77a

Branch: refs/heads/master
Commit: c5a7c77a0b96a33e8a48cb3c200e4b71166c9765
Parents: 7e1ad5b
Author: Jongyoul Lee <jo...@gmail.com>
Authored: Fri Jun 10 20:38:30 2016 +0900
Committer: Jongyoul Lee <jo...@apache.org>
Committed: Mon Jun 13 23:01:47 2016 +0900

----------------------------------------------------------------------
 .../zeppelin/interpreter/remote/RemoteInterpreterServer.java      | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/c5a7c77a/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java
----------------------------------------------------------------------
diff --git a/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java b/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java
index b585e31..9206e8e 100644
--- a/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java
+++ b/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java
@@ -157,7 +157,6 @@ public class RemoteInterpreterServer
           replClass.getConstructor(new Class[] {Properties.class});
       Interpreter repl = constructor.newInstance(p);
 
-      ClassLoader cl = ClassLoader.getSystemClassLoader();
       repl.setClassloaderUrls(new URL[]{});
 
       synchronized (interpreterGroup) {
@@ -167,7 +166,7 @@ public class RemoteInterpreterServer
           interpreterGroup.put(noteId, interpreters);
         }
 
-        interpreters.add(new LazyOpenInterpreter(new ClassloaderInterpreter(repl, cl)));
+        interpreters.add(new LazyOpenInterpreter(repl));
       }
 
       logger.info("Instantiate interpreter {}", className);