[jira] Commented: (SOLR-1917) Possible Null Pointer Exception in highlight or debug component

["David Bowen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12868458#action_12868458 ] 

David Bowen commented on SOLR-1917:
-----------------------------------

By the way, the way this bug showed up was when highlighting was very slow, so that the first query from master to slave (fetching the top ids and scores) was fine, but the second query, to fetch the documents by id, timed out.  



> Possible Null Pointer Exception in highlight or debug component
> ---------------------------------------------------------------
>
>                 Key: SOLR-1917
>                 URL: https://issues.apache.org/jira/browse/SOLR-1917
>             Project: Solr
>          Issue Type: Bug
>          Components: highlighter
>    Affects Versions: 1.4
>            Reporter: David Bowen
>         Attachments: SOLR-1917.patch
>
>
> This bug may only show up if you have the patch for SOLR-1143 installed, but it should be fixed in any case since the existing logic is wrong.  It is explicitly looking for the nulls that can cause the exception, but only after the exception would have already happened.
> What happens is that there is an array of Map.Entry objects which is converted into a SimpleOrderedMap, and then there is a method that iterates over the SimpleOrderedMap looking for null names.  That's wrong because it is the array elements themselves which can be null, so constructing the SimpleOrderedMap throws an NPE.
> I will attach a patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org