You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/06/25 12:00:26 UTC

[GitHub] liubao68 commented on issue #774: [SCB-685] Service comb chassis must support default values in query parameters

liubao68 commented on issue #774: [SCB-685] Service comb chassis must support default values in query parameters
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/774#issuecomment-399927002
 
 
   I'll merge this PR. Following work need to be done:
   1. Support JAX-RS
   2. Adding more test cases, to cover default values not specified and user do not parse any value. See review comments: " Maybe it's better to return ValueConstants.DEFAULT_NONE. When no default value specified and users do not give the parameter value, we can throw an BadRequest exception or give default value based on parameter type, e.g. int is 0 and String is null."

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services