You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2023/05/17 16:06:27 UTC
[GitHub] [superset] rusackas opened a new pull request, #24101: chore(Bard): re-enabling and de-flaking a Cypress test (in theory)
rusackas opened a new pull request, #24101:
URL: https://github.com/apache/superset/pull/24101
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This test was previously `xit`-ed in [another PR](https://github.com/apache/superset/pull/23772) because it was the flakiest of all tests. Let's see if Bard can fix that!
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24101: chore(Bard): re-enabling and de-flaking a Cypress test (in theory)
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24101:
URL: https://github.com/apache/superset/pull/24101#issuecomment-1551700536
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24101?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24101](https://app.codecov.io/gh/apache/superset/pull/24101?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (2bdf384) into [master](https://app.codecov.io/gh/apache/superset/commit/51929255bae696cafe657db381dcf4d0b5f91828?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (5192925) will **increase** coverage by `2.85%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #24101 +/- ##
==========================================
+ Coverage 54.10% 56.95% +2.85%
==========================================
Files 1951 1951
Lines 75360 75385 +25
Branches 8185 8185
==========================================
+ Hits 40773 42938 +2165
+ Misses 32484 30344 -2140
Partials 2103 2103
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| presto | `53.12% <ø> (ø)` | |
| python | `59.36% <ø> (+5.90%)` | :arrow_up: |
| unit | `53.11% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 126 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24101/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas closed pull request #24101: chore(Bard): re-enabling and de-flaking a Cypress test (in theory)
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #24101: chore(Bard): re-enabling and de-flaking a Cypress test (in theory)
URL: https://github.com/apache/superset/pull/24101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org