You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/02/02 20:17:06 UTC
[kudu-CR] [docker] Add a docker-compose example
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12343
Change subject: [docker] Add a docker-compose example
......................................................................
[docker] Add a docker-compose example
Adds a brief example of how to start, scale, and
stop a Kudu cluster useing docker-compose.
Change-Id: Ie3ac3f9fca16b3bddf45ba24f6e6aa1efcee857c
---
M docker/README.adoc
A docker/docker-compose.yml
2 files changed, 72 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/12343/1
--
To view, visit http://gerrit.cloudera.org:8080/12343
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie3ac3f9fca16b3bddf45ba24f6e6aa1efcee857c
Gerrit-Change-Number: 12343
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [docker] Add a docker-compose example
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12343 )
Change subject: [docker] Add a docker-compose example
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/12343/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12343/2//COMMIT_MSG@10
PS2, Line 10: useing
> using
Done
http://gerrit.cloudera.org:8080/#/c/12343/2/docker/README.adoc
File docker/README.adoc:
http://gerrit.cloudera.org:8080/#/c/12343/2/docker/README.adoc@67
PS2, Line 67: kudu-tserver=
> Does there need to be a value after the equals sign? If it's up to the user
Done
http://gerrit.cloudera.org:8080/#/c/12343/2/docker/docker-compose.yml
File docker/docker-compose.yml:
PS2:
> Can you add a license header to this file?
Done
http://gerrit.cloudera.org:8080/#/c/12343/2/docker/docker-compose.yml@10
PS2, Line 10: - KUDU_MASTERS=kudu-master-1,kudu-master-2,kudu-master-3
> This is converted into something useful by a script, right? Both for master
That is something useful, those are valid hostnames from inside the containers.
--
To view, visit http://gerrit.cloudera.org:8080/12343
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3ac3f9fca16b3bddf45ba24f6e6aa1efcee857c
Gerrit-Change-Number: 12343
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 03 Feb 2019 20:31:33 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docker] Add a docker-compose example
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: [docker] Add a docker-compose example
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/12343
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ie3ac3f9fca16b3bddf45ba24f6e6aa1efcee857c
Gerrit-Change-Number: 12343
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docker] Add a docker-compose example
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12343 )
Change subject: [docker] Add a docker-compose example
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12343
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3ac3f9fca16b3bddf45ba24f6e6aa1efcee857c
Gerrit-Change-Number: 12343
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 04 Feb 2019 05:05:48 +0000
Gerrit-HasComments: No
[kudu-CR] [docker] Add a docker-compose example
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12343 )
Change subject: [docker] Add a docker-compose example
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12343/3/docker/README.adoc
File docker/README.adoc:
http://gerrit.cloudera.org:8080/#/c/12343/3/docker/README.adoc@101
PS3, Line 101: kudu-base
> Nit: kudu:base (lower-case k).
Done
--
To view, visit http://gerrit.cloudera.org:8080/12343
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3ac3f9fca16b3bddf45ba24f6e6aa1efcee857c
Gerrit-Change-Number: 12343
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 04 Feb 2019 05:01:25 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docker] Add a docker-compose example
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12343 )
Change subject: [docker] Add a docker-compose example
......................................................................
Patch Set 2:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/12343/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12343/2//COMMIT_MSG@10
PS2, Line 10: useing
using
http://gerrit.cloudera.org:8080/#/c/12343/2/docker/README.adoc
File docker/README.adoc:
http://gerrit.cloudera.org:8080/#/c/12343/2/docker/README.adoc@67
PS2, Line 67: kudu-tserver=
Does there need to be a value after the equals sign? If it's up to the user, maybe indicate that with an argument surrounded by triangular brackets?
http://gerrit.cloudera.org:8080/#/c/12343/2/docker/docker-compose.yml
File docker/docker-compose.yml:
PS2:
Can you add a license header to this file?
http://gerrit.cloudera.org:8080/#/c/12343/2/docker/docker-compose.yml@10
PS2, Line 10: - KUDU_MASTERS=kudu-master-1,kudu-master-2,kudu-master-3
This is converted into something useful by a script, right? Both for masters and tservers?
--
To view, visit http://gerrit.cloudera.org:8080/12343
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3ac3f9fca16b3bddf45ba24f6e6aa1efcee857c
Gerrit-Change-Number: 12343
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 03 Feb 2019 19:15:34 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docker] Add a docker-compose example
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12343 )
Change subject: [docker] Add a docker-compose example
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12343
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3ac3f9fca16b3bddf45ba24f6e6aa1efcee857c
Gerrit-Change-Number: 12343
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 04 Feb 2019 05:14:44 +0000
Gerrit-HasComments: No
[kudu-CR] [docker] Add a docker-compose example
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12343 )
Change subject: [docker] Add a docker-compose example
......................................................................
[docker] Add a docker-compose example
Adds a brief example of how to start, scale, and
stop a Kudu cluster using docker-compose.
Change-Id: Ie3ac3f9fca16b3bddf45ba24f6e6aa1efcee857c
Reviewed-on: http://gerrit.cloudera.org:8080/12343
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Grant Henke <gr...@apache.org>
Tested-by: Kudu Jenkins
---
M docker/README.adoc
A docker/docker-compose.yml
M docker/kudu-entrypoint.sh
3 files changed, 98 insertions(+), 7 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Grant Henke: Verified
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12343
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie3ac3f9fca16b3bddf45ba24f6e6aa1efcee857c
Gerrit-Change-Number: 12343
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docker] Add a docker-compose example
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12343
to look at the new patch set (#3).
Change subject: [docker] Add a docker-compose example
......................................................................
[docker] Add a docker-compose example
Adds a brief example of how to start, scale, and
stop a Kudu cluster using docker-compose.
Change-Id: Ie3ac3f9fca16b3bddf45ba24f6e6aa1efcee857c
---
M docker/README.adoc
A docker/docker-compose.yml
M docker/kudu-entrypoint.sh
3 files changed, 98 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/12343/3
--
To view, visit http://gerrit.cloudera.org:8080/12343
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie3ac3f9fca16b3bddf45ba24f6e6aa1efcee857c
Gerrit-Change-Number: 12343
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docker] Add a docker-compose example
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12343
to look at the new patch set (#4).
Change subject: [docker] Add a docker-compose example
......................................................................
[docker] Add a docker-compose example
Adds a brief example of how to start, scale, and
stop a Kudu cluster using docker-compose.
Change-Id: Ie3ac3f9fca16b3bddf45ba24f6e6aa1efcee857c
---
M docker/README.adoc
A docker/docker-compose.yml
M docker/kudu-entrypoint.sh
3 files changed, 98 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/12343/4
--
To view, visit http://gerrit.cloudera.org:8080/12343
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie3ac3f9fca16b3bddf45ba24f6e6aa1efcee857c
Gerrit-Change-Number: 12343
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docker] Add a docker-compose example
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12343 )
Change subject: [docker] Add a docker-compose example
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12343
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3ac3f9fca16b3bddf45ba24f6e6aa1efcee857c
Gerrit-Change-Number: 12343
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 02 Feb 2019 22:44:28 +0000
Gerrit-HasComments: No
[kudu-CR] [docker] Add a docker-compose example
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12343 )
Change subject: [docker] Add a docker-compose example
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12343/3/docker/README.adoc
File docker/README.adoc:
http://gerrit.cloudera.org:8080/#/c/12343/3/docker/README.adoc@101
PS3, Line 101: Kudu:base
Nit: kudu:base (lower-case k).
http://gerrit.cloudera.org:8080/#/c/12343/2/docker/docker-compose.yml
File docker/docker-compose.yml:
http://gerrit.cloudera.org:8080/#/c/12343/2/docker/docker-compose.yml@10
PS2, Line 10: #
> That is something useful, those are valid hostnames from inside the contain
Sorry, I meant "KUDU_MASTERS" (i.e. I couldn't remember where that environment variable gets used). Since then I reviewed the rest of your changes and saw it in the entrypoint script.
--
To view, visit http://gerrit.cloudera.org:8080/12343
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3ac3f9fca16b3bddf45ba24f6e6aa1efcee857c
Gerrit-Change-Number: 12343
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 04 Feb 2019 04:30:30 +0000
Gerrit-HasComments: Yes