Massive Fineract automated code reformatting (FINERACT-1006)

[Michael Vorburger <mi...@vorburger.ch>]

Developers,

This email is a heads up to inform everyone that we would like to soon
commit and merge a very massive automated code re-formatting in Fineract
(non-CN).

This will be a one-time bulk change of approx. 2700 (!) source files in the
Fineract code base. This will have no functional impact.

You can learn more about the full background about this by reading
https://issues.apache.org/jira/browse/FINERACT-1006 and
https://github.com/apache/fineract/pull/943.

This most likely WILL cause some pain and merge conflicts on all currently
still open and un-merged PRs. (Not to speak about likely wreaking havoc on
anyone crazy enough to try to keep a secret in-house downstream fork
rebased on the upstream project source repository... but that is not really
this project's problem - just come and join the party by contributing
upstream, instead of working downstream in your forks!)

There never really is "good" time to do this kind of thing. I propose that
I do it this Sunday afternoon CET - in a bit less than 72h from now. If
anyone reading this has strong objections to it, please speak up now - or
be silent forever after... ;-) I also don't mind at all doing it only e.g.
in max. 1 week, if anyone needs a little bit of time to... catch up to
finish their pending PRs - or something. Please shout if that is your case.

Thank you,
Michael
_______________________
Michael Vorburger
http://www.vorburger.ch

Re: Massive Fineract automated code reformatting (FINERACT-1006)

[James Dailey <ja...@gmail.com>]

I'm a little concerned the folks at some of the soft forks won't be able to
deal w this and may not see the post in time.  Perhaps the dev branch can
be tagged, or a special log entry made on the last known check in before
this massive change??  (I.E. all of the mifosX deployed solutions who have
only seen minor changes to code since 2017 )

 +1
Emphasize make sure you are working upstream.

 E.g. found this tutorial:
https://www.atlassian.com/git/tutorials/git-forks-and-upstreams





On Thu, Jun 11, 2020, 4:10 PM Ed Cable <ed...@mifos.org> wrote:

> Michael,
>
> Thanks for the heads up to the community. Great work and a hat tip to
> @manthansurkar@gmail.com <ma...@gmail.com> for all the effort
> that went into this and to @Michael Vorburger <mi...@vorburger.ch> @Yemdjih
> Kaze Nasser <ka...@gmail.com> and @Yannick Awasum
> <ya...@gmail.com> for reviewing the work.
>
> Thanks for giving that kind warning to all of those downstream forks about
> this massive change coming to the upstream.
>
> Ed
>
> On Thu, Jun 11, 2020 at 3:50 PM Michael Vorburger <mi...@vorburger.ch>
> wrote:
>
>> Developers,
>>
>> This email is a heads up to inform everyone that we would like to soon
>> commit and merge a very massive automated code re-formatting in Fineract
>> (non-CN).
>>
>> This will be a one-time bulk change of approx. 2700 (!) source files in
>> the Fineract code base. This will have no functional impact.
>>
>> You can learn more about the full background about this by reading
>> https://issues.apache.org/jira/browse/FINERACT-1006 and
>> https://github.com/apache/fineract/pull/943.
>>
>> This most likely WILL cause some pain and merge conflicts on all
>> currently still open and un-merged PRs. (Not to speak about likely wreaking
>> havoc on anyone crazy enough to try to keep a secret in-house downstream
>> fork rebased on the upstream project source repository... but that is not
>> really this project's problem - just come and join the party by
>> contributing upstream, instead of working downstream in your forks!)
>>
>> There never really is "good" time to do this kind of thing. I propose
>> that I do it this Sunday afternoon CET - in a bit less than 72h from now.
>> If anyone reading this has strong objections to it, please speak up now -
>> or be silent forever after... ;-) I also don't mind at all doing it only
>> e.g. in max. 1 week, if anyone needs a little bit of time to... catch up to
>> finish their pending PRs - or something. Please shout if that is your case.
>>
>> Thank you,
>> Michael
>> _______________________
>> Michael Vorburger
>> http://www.vorburger.ch
>>
>
>
> --
> *Ed Cable*
> President/CEO, Mifos Initiative
> edcable@mifos.org | Skype: edcable | Mobile: +1.484.477.8649
>
> *Collectively Creating a World of 3 Billion Maries | *http://mifos.org
> <http://facebook.com/mifos>  <http://www.twitter.com/mifos>
>
>

Re: Massive Fineract automated code reformatting (FINERACT-1006)

[Ed Cable <ed...@mifos.org>]

Michael,

Thanks for the heads up to the community. Great work and a hat tip to
@manthansurkar@gmail.com <ma...@gmail.com> for all the effort that
went into this and to @Michael Vorburger <mi...@vorburger.ch> @Yemdjih Kaze
Nasser <ka...@gmail.com> and @Yannick Awasum <ya...@gmail.com> for
reviewing the work.

Thanks for giving that kind warning to all of those downstream forks about
this massive change coming to the upstream.

Ed

On Thu, Jun 11, 2020 at 3:50 PM Michael Vorburger <mi...@vorburger.ch> wrote:

> Developers,
>
> This email is a heads up to inform everyone that we would like to soon
> commit and merge a very massive automated code re-formatting in Fineract
> (non-CN).
>
> This will be a one-time bulk change of approx. 2700 (!) source files in
> the Fineract code base. This will have no functional impact.
>
> You can learn more about the full background about this by reading
> https://issues.apache.org/jira/browse/FINERACT-1006 and
> https://github.com/apache/fineract/pull/943.
>
> This most likely WILL cause some pain and merge conflicts on all currently
> still open and un-merged PRs. (Not to speak about likely wreaking havoc on
> anyone crazy enough to try to keep a secret in-house downstream fork
> rebased on the upstream project source repository... but that is not really
> this project's problem - just come and join the party by contributing
> upstream, instead of working downstream in your forks!)
>
> There never really is "good" time to do this kind of thing. I propose that
> I do it this Sunday afternoon CET - in a bit less than 72h from now. If
> anyone reading this has strong objections to it, please speak up now - or
> be silent forever after... ;-) I also don't mind at all doing it only e.g.
> in max. 1 week, if anyone needs a little bit of time to... catch up to
> finish their pending PRs - or something. Please shout if that is your case.
>
> Thank you,
> Michael
> _______________________
> Michael Vorburger
> http://www.vorburger.ch
>


-- 
*Ed Cable*
President/CEO, Mifos Initiative
edcable@mifos.org | Skype: edcable | Mobile: +1.484.477.8649

*Collectively Creating a World of 3 Billion Maries | *http://mifos.org
<http://facebook.com/mifos>  <http://www.twitter.com/mifos>